From: Mark Brown <broonie@kernel.org>
To: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Support Opensource <support.opensource@diasemi.com>
Subject: Re: [PATCH 1/2] ASoC: da7218: Add bindings documentation for DA7218 audio codec
Date: Thu, 5 Nov 2015 14:58:56 +0000 [thread overview]
Message-ID: <20151105145856.GM18409@sirena.org.uk> (raw)
In-Reply-To: <b7132781a4a41a20549e13b1835bb7f808f6be82.1446718490.git.Adam.Thomson.Opensource@diasemi.com>
[-- Attachment #1: Type: text/plain, Size: 724 bytes --]
On Thu, Nov 05, 2015 at 10:43:15AM +0000, Adam Thomson wrote:
> +- dlg,ldo-lvl : Required internal LDO voltage (mV) level
> + [<1050>, <1100>, <1200>, <1400>]
Why would this ever be anything other than the minimum voltage, and
might we not want to vary it at runtime?
> +- dlg,biquad-cfg : List of data & address pairs to configure BiQuad filters
> + [ < {data1} {addr1} {data2} {addr2} ... >; ]
> +- dlg,st-biquad-cfg : List of data & address pairs to configure Sidetone
> + BiQuad filters
> + [ < {data1} {addr1} {data2} {addr2} ... >; ]
These look like DSP coefficients which I would therefore expect to be
configurable at runtime via a binary control rather than specified in
the DT - why are they in the DT?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-11-05 14:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 10:43 [PATCH 0/2] ASoC: Add support for DA7217 and DA7218 audio codecs Adam Thomson
2015-11-05 10:43 ` [PATCH 1/2] ASoC: da7218: Add bindings documentation for DA7218 audio codec Adam Thomson
2015-11-05 14:58 ` Mark Brown [this message]
2015-11-05 17:59 ` Opensource [Adam Thomson]
2015-11-06 10:30 ` Mark Brown
2015-11-05 10:43 ` [PATCH 2/2] ASoC: codecs: Add da7218 codec driver Adam Thomson
2015-11-05 15:27 ` Mark Brown
2015-11-06 11:11 ` Opensource [Adam Thomson]
2015-11-06 11:21 ` Mark Brown
2015-11-06 11:53 ` Opensource [Adam Thomson]
2015-11-06 11:54 ` Mark Brown
2015-11-06 13:17 ` Opensource [Adam Thomson]
2015-11-08 10:34 ` Mark Brown
2015-11-09 12:28 ` Opensource [Adam Thomson]
2015-11-09 14:02 ` Mark Brown
2015-11-10 13:55 ` Opensource [Adam Thomson]
2015-11-10 14:15 ` Mark Brown
2015-11-10 14:24 ` Opensource [Adam Thomson]
2015-11-10 15:44 ` Mark Brown
2015-11-10 16:21 ` Opensource [Adam Thomson]
2015-11-10 16:42 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151105145856.GM18409@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=support.opensource@diasemi.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®