From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033010AbbKEPFm (ORCPT ); Thu, 5 Nov 2015 10:05:42 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:48540 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032707AbbKEPFl (ORCPT ); Thu, 5 Nov 2015 10:05:41 -0500 Date: Thu, 5 Nov 2015 15:05:29 +0000 From: Mark Brown To: Masahiro Yamada Cc: Linux Kernel Mailing List , Philipp Zabel , linux-spi@vger.kernel.org Message-ID: <20151105150529.GN18409@sirena.org.uk> References: <1446722128-11961-1-git-send-email-yamada.masahiro@socionext.com> <1446722128-11961-3-git-send-email-yamada.masahiro@socionext.com> <20151105112847.GA18409@sirena.org.uk> <20151105122038.GF18409@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uMPAU7A2Er6+wvsD" Content-Disposition: inline In-Reply-To: X-Cookie: Put your trust in those who are worthy. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 94.197.121.29 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER" X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --uMPAU7A2Er6+wvsD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 05, 2015 at 09:32:15PM +0900, Masahiro Yamada wrote: > For compile test, right, "depends on RESET_CONTROLLER" is > redundant in the first place. > For run-time on real SoCs,the driver failed at the following point > without the reset-controller sub-system. Your changelog needs to say this clearly, right now what it's saying clearly doesn't correspond to what the change does. --uMPAU7A2Er6+wvsD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWO3A4AAoJECTWi3JdVIfQSBAH/Aiuhd6HtxSsgl3elvMw9QdR cD75iTuvZVEbaht/+s/4na/RRoAc78HGtPIBlC7A2O3ZXWerZ4eSQh42x8CgeCsx JS/7Ko5UU0m8wKuM/lthLkttxKX1qZ6KpldCPEPNiqHW7OSriVFaTrhsnWFssNZZ M3ltHzAh2AzmrkD6JSykGYB9rKB3+wNHTD5Ok46LRb+abRS++74I/LglevfbT+mQ b5a+EM6923EWeiw87FZp24ZKtFvDK88GDoj+OSEeUIR+SBJHOcKf3iPp/eeNHcjP NTHEMsX+518bmhpihuvfSmTg5sKwJ0DJczYZkRtaHX3So2Yj/VL67s7tORcYV7Y= =Gubt -----END PGP SIGNATURE----- --uMPAU7A2Er6+wvsD--