mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Klaus Ethgen <Klaus+lkml@ethgen.de>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Richard Weinberger <richard.weinberger@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Christoph Lameter <cl@linux.com>,
	Andy Lutomirski <luto@kernel.org>,
	Serge Hallyn <serge.hallyn@ubuntu.com>,
	Kees Cook <keescook@chromium.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [KERNEL] Re: [KERNEL] Re: [KERNEL] Re: Kernel 4.3 breaks security in systems  using capabilities
Date: Thu, 5 Nov 2015 18:22:59 +0100	[thread overview]
Message-ID: <20151105172259.GC9307@ikki.ethgen.ch> (raw)
In-Reply-To: <CALCETrVBON+MTfiC1hAbbUudfpJeKWdvt1yGx=B7L+xQAmyn3w@mail.gmail.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hi,

Am Do den  5. Nov 2015 um 17:19 schrieb Andy Lutomirski:
> > With the present way, that was no problem (for OSS). You take away the
> > SUID, set the capabilities and if the tool complains about not being
> > root, look into the code and remove that stupid thing. With ambient
> > capabilities, no one will see that the tool is doing such stupid thing
> > as setting all capabilities unless some trouble is seen.
> 
> SUID is, always has been, and always will be a minefield.  People
> writing SUID programs need to do it right.  When the kernel adds a new
> API, doing it right includes not adding a buggy call to the API.

Thats right. But real world is not optimal.

> The ambient capability code explicitly zeros pA when running a SUID
> binary to avoid problems in which a SUID binary has unexpected ambient
> capabilities.

That is not the point. I do not talk about combining SUID and
capabilities. I even seen that it was implemented that way. I talk about
taking away rights from tools that don't need it.

> IMO the right long term solution is to just stop using SUID and to
> stop using any other mechanism that grants new privileges of any sort
> when execve is called.

Right. That is my intention.

> When you can boot a distro with no_new_privs
> set everywhere (including init) and everything works, then I'll think
> we've made considerable progress.

That might be a longer way to go. I also don't think it it fully doable.
You do always need some applications having special rights. But I like
to pick exactly that rights instead using sudo or SUID.

Regards
   Klaus
- -- 
Klaus Ethgen                              http://www.ethgen.ch/
pub  4096R/4E20AF1C 2011-05-16   Klaus Ethgen <Klaus@Ethgen.de>
Fingerprint: 85D4 CA42 952C 949B 1753  62B3 79D0 B06F 4E20 AF1C
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQGcBAEBCgAGBQJWO5BzAAoJEKZ8CrGAGfas948L/jde8spo8N+vo+jqVSjRNIsV
M1gHTJ4cahDvKhlK6z2a/5kQSINWP94Ir4LSNh+Qyvvq1ZIDBvVWIgadf4zf7TEf
QfbgKFcdbJaXhWKjdgIaT8LTjRzvyqHGD9F8hoSAYI+zvjOJP3FpXi+1u4QNVcO6
ZiV1Ss+8hUGy44Y2If0yMwYe/Z88elqMOPGHJhqeq44unWG0ZFek5R2xOg2g9qed
MMSz49BLarg0TI9tMO7uwkMXfmhKDh3L0Tdwr6xANwPuaBe5qnFVpQpJ/T/AESv7
uTtzDEjJwN9ZBZra8Zc/Xp02ELoMigAtEWprkl78dEmtKUJnej3MP9xivc6EtKAK
zKunFCmltjwVAtwdggBN+XuJofqltFt0FZpyfX3AwjNrW5ltkXbA/tNL0zoQalqX
+NoFmdEWdi5PcMdxKNoZp7jwrSYG7UN8KDe7ZsSGqrV6iH+pd1KWNog8LOdU3t+W
IfbKdHqVQkIKyYz2R9Dd/o2XnUYpymE75SsZu+6Yhw==
=ffr7
-----END PGP SIGNATURE-----

  reply	other threads:[~2015-11-05 17:23 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-02 18:06 Klaus Ethgen
2015-11-02 18:38 ` Richard Weinberger
2015-11-02 18:50   ` Andy Lutomirski
2015-11-02 19:16     ` [KERNEL] " Klaus Ethgen
2015-11-02 19:45       ` Andy Lutomirski
2015-11-05 10:19         ` [KERNEL] " Klaus Ethgen
2015-11-05 16:15           ` Serge E. Hallyn
2015-11-05 17:17             ` [KERNEL] " Klaus Ethgen
2015-11-05 17:34               ` Serge E. Hallyn
2015-11-05 17:48                 ` [KERNEL] " Klaus Ethgen
2015-11-05 19:01                   ` Andy Lutomirski
2015-11-05 22:08                     ` Serge E. Hallyn
2015-11-06 13:58                       ` [KERNEL] " Klaus Ethgen
2015-11-06 15:53                         ` Theodore Ts'o
2015-11-06 17:15                           ` Andy Lutomirski
2015-11-06 17:51                           ` Casey Schaufler
2015-11-06 18:05                             ` Serge E. Hallyn
2015-11-06 17:56                           ` [KERNEL] " Klaus Ethgen
2015-11-06 18:18                             ` Serge E. Hallyn
2015-11-07 11:02                               ` [KERNEL] " Klaus Ethgen
2015-11-08 17:05                                 ` Serge E. Hallyn
2015-11-09 16:28                                 ` Austin S Hemmelgarn
2015-11-09 17:23                                   ` [KERNEL] " Klaus Ethgen
2015-11-09 19:02                                     ` Austin S Hemmelgarn
2015-11-09 21:29                                       ` [KERNEL] " Klaus Ethgen
2015-11-10  0:06                                         ` Andy Lutomirski
2015-11-10 11:55                                           ` [KERNEL] " Klaus Ethgen
2015-11-10 12:40                                             ` Theodore Ts'o
2015-11-10 13:19                                               ` [KERNEL] [PATCH] " Klaus Ethgen
2015-11-10 13:35                                                 ` Austin S Hemmelgarn
2015-11-10 17:58                                                   ` [KERNEL] " Klaus Ethgen
2015-11-10 20:39                                                     ` Austin S Hemmelgarn
2015-11-10 13:41                                                 ` Klaus Ethgen
2015-11-11  2:04                                                 ` Theodore Ts'o
2015-11-11 10:14                                                   ` [KERNEL] " Klaus Ethgen
2015-11-11 10:54                                                     ` Theodore Ts'o
2015-11-11 11:13                                                       ` [KERNEL] " Klaus Ethgen
2015-11-10 15:25                                               ` [KERNEL] Re: [KERNEL] Re: [KERNEL] " Christoph Lameter
2015-11-05 16:19           ` Andy Lutomirski
2015-11-05 17:22             ` Klaus Ethgen [this message]
2015-11-02 18:52   ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151105172259.GC9307@ikki.ethgen.ch \
    --to=klaus+lkml@ethgen.de \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=luto@kernel.org \
    --cc=richard.weinberger@gmail.com \
    --cc=serge.hallyn@ubuntu.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome