From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932956AbbKFApH (ORCPT ); Thu, 5 Nov 2015 19:45:07 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:59414 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932766AbbKFApE (ORCPT ); Thu, 5 Nov 2015 19:45:04 -0500 Date: Thu, 5 Nov 2015 16:45:02 -0800 From: Guenter Roeck To: Shuah Khan Cc: rydberg@bitmath.org, jdelvare@suse.de, lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hwmon/applesmc: Fix uninitialized variables warnings Message-ID: <20151106004502.GB32106@roeck-us.net> References: <1446763167-7716-1-git-send-email-shuahkh@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1446763167-7716-1-git-send-email-shuahkh@osg.samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 05, 2015 at 03:39:27PM -0700, Shuah Khan wrote: > Fix the following "maybe used uninitialized" warnings by > initializing the variables to keep the compiler quiet. > There is no "used uninitialized" in this case. > > CC [M] drivers/hwmon/applesmc.o > drivers/hwmon/applesmc.c: In function ‘applesmc_init_smcreg’: > drivers/hwmon/applesmc.c:595:43: warning: ‘right_light_sensor’ > may be used uninitialized in this function [-Wmaybe-uninitialized] > s->num_light_sensors = left_light_sensor + right_light_sensor; > ^ > drivers/hwmon/applesmc.c:540:26: note: ‘right_light_sensor’ was > declared here > bool left_light_sensor, right_light_sensor; > ^ > drivers/hwmon/applesmc.c:595:43: warning: ‘left_light_sensor’ may > be used uninitialized in this function [-Wmaybe-uninitialized] > s->num_light_sensors = left_light_sensor + right_light_sensor; > ^ > drivers/hwmon/applesmc.c:540:7: note: ‘left_light_sensor’ was > declared here > bool left_light_sensor, right_light_sensor; > ^ > > Signed-off-by: Shuah Khan Applied. Thanks, Guenter