From: Mark Brown <broonie@kernel.org>
To: Shunqian Zheng <zhengsq@rock-chips.com>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
heiko@sntech.de, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.com, benzh@chromium.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2 1/2] ASoC: codec: Inno codec driver for RK3036 SoC
Date: Fri, 6 Nov 2015 09:28:42 +0000 [thread overview]
Message-ID: <20151106092842.GT18409@sirena.org.uk> (raw)
In-Reply-To: <563C61A9.2080105@rock-chips.com>
[-- Attachment #1: Type: text/plain, Size: 570 bytes --]
On Fri, Nov 06, 2015 at 04:15:37PM +0800, Shunqian Zheng wrote:
> On 2015年11月06日 00:13, Mark Brown wrote:
> >On Thu, Nov 05, 2015 at 05:53:13PM +0800, Shunqian Zheng wrote:
> >This looks like a simple boolean control rather than an enum - it looks
> >like it's just turning antipop on and off.
> It is a boolean control, but it takes 2 bits -- the value of "on" is b10 and
> b01 for "off".
> So I try to use VALUE_ENUM.
The presentation of the control to userspace needs to be a Switch, this
is probably going to need you to code something custom.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-11-06 9:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 9:53 [PATCH v2 0/2] Audio Codec Driver of " Shunqian Zheng
2015-11-05 9:53 ` [PATCH v2 1/2] ASoC: codec: Inno codec driver for " Shunqian Zheng
2015-11-05 12:47 ` LABBE Corentin
2015-11-06 8:06 ` Shunqian Zheng
2015-11-05 16:13 ` Mark Brown
2015-11-06 8:15 ` Shunqian Zheng
2015-11-06 9:28 ` Mark Brown [this message]
2015-11-05 9:53 ` [PATCH v2 2/2] ASoC: RK3036: Add binding doc of inno-rk3036 codec driver Shunqian Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151106092842.GT18409@sirena.org.uk \
--to=broonie@kernel.org \
--cc=benzh@chromium.org \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
--cc=zhengsq@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®