From: Mark Brown <broonie@kernel.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-spi@vger.kernel.org
Subject: Re: [RFC PATCH 3/7] spi: tegra: remove redundant "depends on RESET_CONTROLLER"
Date: Fri, 6 Nov 2015 10:22:37 +0000 [thread overview]
Message-ID: <20151106102237.GX18409@sirena.org.uk> (raw)
In-Reply-To: <CAK7LNAR6Mx4+E-8W5weSN2MyAgkMy6MFMxRQEDvrDftCW92ixw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 741 bytes --]
On Fri, Nov 06, 2015 at 03:02:57PM +0900, Masahiro Yamada wrote:
> 2015-11-05 20:50 GMT+09:00 Mark Brown <broonie@kernel.org>:
> > On Thu, Nov 05, 2015 at 08:15:24PM +0900, Masahiro Yamada wrote:
> >> ARCH_TEGRA selects RESET_CONTROLLER.
> >> The dependency "depends on RESET_CONTROLLER" is already met.
> >> tristate "NVIDIA Tegra114 SPI Controller"
> >> depends on (ARCH_TEGRA && TEGRA20_APB_DMA) || COMPILE_TEST
> >> - depends on RESET_CONTROLLER && HAS_DMA
> >> + depends on HAS_DMA
> > Again, this driver doesn't depend on ARCH_TEGRA.
> How come?
> Sorry, I have not been tracking this sub-system,
> so I do not get the "Again".
It's the same issue as your previous patch - there's an || COMPILE_TEST
in there.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-11-06 10:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 11:15 [RFC PATCH 0/7] reset: make RESET_CONTROLLER a select'ed option Masahiro Yamada
2015-11-05 11:15 ` [RFC PATCH 1/7] reset: drop ARCH_HAS_RESET_CONTROLLER Masahiro Yamada
2015-11-05 11:15 ` [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER" Masahiro Yamada
2015-11-05 11:28 ` Mark Brown
2015-11-05 12:11 ` Masahiro Yamada
2015-11-05 12:20 ` Mark Brown
2015-11-05 12:32 ` Masahiro Yamada
2015-11-05 15:05 ` Mark Brown
2015-11-06 6:00 ` Masahiro Yamada
2015-11-06 10:21 ` Mark Brown
2015-11-05 11:15 ` [RFC PATCH 3/7] spi: tegra: " Masahiro Yamada
2015-11-05 11:50 ` Mark Brown
2015-11-06 6:02 ` Masahiro Yamada
2015-11-06 10:22 ` Mark Brown [this message]
2015-11-05 11:15 ` [RFC PATCH 4/7] pinctrl: sunxi: " Masahiro Yamada
2015-11-05 13:40 ` Linus Walleij
2015-11-05 14:06 ` Linus Walleij
2015-11-16 3:40 ` Masahiro Yamada
2015-11-17 14:03 ` Linus Walleij
2015-11-05 11:15 ` [RFC PATCH 5/7] drm/sti: replace "select RESET_CONTROLLER" with "depends on ..." Masahiro Yamada
2015-11-05 11:15 ` [RFC PATCH 6/7] drm/rockchip: remove redundant "depends on RESET_CONTROLLER" Masahiro Yamada
2015-11-05 11:15 ` [RFC PATCH 7/7] drm/tegra: tegra: " Masahiro Yamada
2015-11-05 14:49 ` [RFC PATCH 0/7] reset: make RESET_CONTROLLER a select'ed option Arnd Bergmann
2015-11-06 5:58 ` Masahiro Yamada
2015-11-06 9:29 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151106102237.GX18409@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®