From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161179AbbKFLWN (ORCPT ); Fri, 6 Nov 2015 06:22:13 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:49665 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031997AbbKFLWK (ORCPT ); Fri, 6 Nov 2015 06:22:10 -0500 Date: Fri, 6 Nov 2015 11:21:41 +0000 From: Mark Brown To: "Opensource [Adam Thomson]" Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "alsa-devel@alsa-project.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Support Opensource Message-ID: <20151106112141.GE18409@sirena.org.uk> References: <01a9b6e96b66327cf9a27781c13aa50545380acb.1446718490.git.Adam.Thomson.Opensource@diasemi.com> <20151105152736.GO18409@sirena.org.uk> <2E89032DDAA8B9408CB92943514A0337D460CA0C@SW-EX-MBX01.diasemi.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SqEuGDw53xMPnx3c" Content-Disposition: inline In-Reply-To: <2E89032DDAA8B9408CB92943514A0337D460CA0C@SW-EX-MBX01.diasemi.com> X-Cookie: Put your trust in those who are worthy. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 217.140.96.141 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 2/2] ASoC: codecs: Add da7218 codec driver X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --SqEuGDw53xMPnx3c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Nov 06, 2015 at 11:11:38AM +0000, Opensource [Adam Thomson] wrote: > On November 5, 2015 15:28, Mark Brown wrote: > > > +static int da7218_mic_lvl_det_sw_put(struct snd_kcontrol *kcontrol, > > > + struct snd_ctl_elem_value *ucontrol) > > > +{ > > Why is this a user visible control? > I can envisage in a system you may want to choose which capture channels can > trigger level detection (if any), and this may change depending on the use-case > at the time, so having it as a control makes sense to me. What is a "capture channel" here? --SqEuGDw53xMPnx3c Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWPI1BAAoJECTWi3JdVIfQinwH/0YBLaeoxEDWZM2SRf23/7OZ /0Re3FtooatAyplUdqwyT8UZezCYuW94EA5fRuhgUslcja+wxfPrbbXk9lBPgpWs htwFXfLY7Y0Yl/5CW8P8SiYCAXU1rLNnYwQD1SRHtBWSMdF4cDrH/CNXU7hrfXX9 gGoN0vRSPoWUyXWtqRJUgvIfkIuoAYekOiGvqa+VvvCL+42oSTJFI1+AnMEQAYl6 CmL2xHUyWPjM/xiY6dg9uGcn2Tp1dfoXu9/YYHWDRIU99SXW0nSJFI5TQgjMbIMQ SuEZ2JyerEkyt+K+nzsnIDpXSRuLIhP0tPszvELvGiA6CcL6aJlw2p317EtdQAo= =GlxG -----END PGP SIGNATURE----- --SqEuGDw53xMPnx3c--