From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758234AbbKGCk7 (ORCPT ); Fri, 6 Nov 2015 21:40:59 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:55051 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758172AbbKGCkT (ORCPT ); Fri, 6 Nov 2015 21:40:19 -0500 Date: Fri, 6 Nov 2015 17:13:32 -0800 From: Greg KH To: Paul Davies C Cc: lustre-devel@lists.lustre.org, oleg.drokin@intel.com, andreas.dilger@intel.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] lustre: obdclass: fix sparse warning Message-ID: <20151107011332.GA14291@kroah.com> References: <5635d078.a1ee440a.16126.ffffcaf6@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5635d078.a1ee440a.16126.ffffcaf6@mx.google.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 01, 2015 at 02:12:29PM +0530, Paul Davies C wrote: > Fix the following warning given by sparse: > > drivers/staging/lustre/lustre/obdclass/cl_lock.c:690:5: warning: symbol 'cl_lock_mutex_try' was not declared. Should it be static? > > Signed-off-by: Paul Davies C > --- > drivers/staging/lustre/lustre/obdclass/cl_lock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/lustre/obdclass/cl_lock.c b/drivers/staging/lustre/lustre/obdclass/cl_lock.c > index 5621beb..6f83452 100644 > --- a/drivers/staging/lustre/lustre/obdclass/cl_lock.c > +++ b/drivers/staging/lustre/lustre/obdclass/cl_lock.c > @@ -687,7 +687,7 @@ EXPORT_SYMBOL(cl_lock_mutex_get); > * > * \see cl_lock_mutex_get() > */ > -int cl_lock_mutex_try(const struct lu_env *env, struct cl_lock *lock) > +static int cl_lock_mutex_try(const struct lu_env *env, struct cl_lock *lock) > { > int result; > Someone did this before you did, sorry :(