From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754627AbbKHG6E (ORCPT ); Sun, 8 Nov 2015 01:58:04 -0500 Received: from mail-lb0-f181.google.com ([209.85.217.181]:34247 "EHLO mail-lb0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753516AbbKHG5s (ORCPT ); Sun, 8 Nov 2015 01:57:48 -0500 Date: Sun, 8 Nov 2015 13:37:25 +0700 From: Ivan Safonov To: devel@driverdev.osuosl.org Cc: Greg Kroah-Hartman , Vaishali Thakkar , Jakub Sitnicki , Anish Bhatt , Joe Perches , Ivan Safonov , Nicholas Mc Guire , Alexey Khoroshilov , =?iso-8859-1?Q?R=E9my?= Oudompheng , Sudip Mukherjee , Shraddha Barke , linux-kernel@vger.kernel.org Subject: [PATCH 02/12] staging: rtl8188eu: return value and argument types changed in _rtl88e_write_fw function Message-ID: <20151108063725.GA1073@alpha.sfu-kras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ideally the function should not change the variables outside of its body. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/fw.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c index 4d72537..5b569ef 100644 --- a/drivers/staging/rtl8188eu/hal/fw.c +++ b/drivers/staging/rtl8188eu/hal/fw.c @@ -75,14 +75,14 @@ static void _rtl88e_fw_block_write(struct adapter *adapt, usb_write8(adapt, write_address, byte_buffer[i]); } -static void _rtl88e_fill_dummy(u8 *pfwbuf, u32 *pfwlen) +static u32 _rtl88e_fill_dummy(u8 *pfwbuf, u32 pfwlen) { u32 i; - for (i = *pfwlen; i < roundup(*pfwlen, 4); i++) + for (i = pfwlen; i < roundup(pfwlen, 4); i++) pfwbuf[i] = 0; - *pfwlen = i; + return i; } static void _rtl88e_fw_page_write(struct adapter *adapt, @@ -103,7 +103,7 @@ static void _rtl88e_write_fw(struct adapter *adapt, u8 *buffer, u32 size) u32 page_no, remain; u32 page, offset; - _rtl88e_fill_dummy(buf_ptr, &size); + size = _rtl88e_fill_dummy(buf_ptr, size); page_no = size / FW_8192C_PAGE_SIZE; remain = size % FW_8192C_PAGE_SIZE; -- 2.4.10