From: Ivan Safonov <insafonov@gmail.com>
To: devel@driverdev.osuosl.org
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Vaishali Thakkar" <vthakkar1994@gmail.com>,
"Jakub Sitnicki" <jsitnicki@gmail.com>,
"Anish Bhatt" <anish@gatech.edu>, "Joe Perches" <joe@perches.com>,
"Ivan Safonov" <insafonov@gmail.com>,
"Nicholas Mc Guire" <der.herr@hofr.at>,
"Alexey Khoroshilov" <khoroshilov@ispras.ru>,
"Rémy Oudompheng" <remyoudompheng@gmail.com>,
"Sudip Mukherjee" <sudipm.mukherjee@gmail.com>,
"Shraddha Barke" <shraddha.6596@gmail.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 06/12] staging: rtl8188eu: use memset instead of for loop
Date: Sun, 8 Nov 2015 14:12:06 +0700 [thread overview]
Message-ID: <20151108071206.GA1545@alpha.sfu-kras.ru> (raw)
memset clearer than the for loop.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
---
drivers/staging/rtl8188eu/hal/fw.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c
index 7f1df4d..298e3e8 100644
--- a/drivers/staging/rtl8188eu/hal/fw.c
+++ b/drivers/staging/rtl8188eu/hal/fw.c
@@ -77,12 +77,12 @@ static void _rtl88e_fw_block_write(struct adapter *adapt,
static u32 _rtl88e_fill_dummy(u8 *pfwbuf, u32 pfwlen)
{
- u32 i;
+ u32 remain = round_up(pfwlen, 4) - pfwlen;
- for (i = pfwlen; i < roundup(pfwlen, 4); i++)
- pfwbuf[i] = 0;
+ if (remain)
+ memset(pfwbuf, 0, remain);
- return i;
+ return pfwlen + remain;
}
static void _rtl88e_fw_page_write(struct adapter *adapt,
--
2.4.10
reply other threads:[~2015-11-08 7:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151108071206.GA1545@alpha.sfu-kras.ru \
--to=insafonov@gmail.com \
--cc=anish@gatech.edu \
--cc=der.herr@hofr.at \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=jsitnicki@gmail.com \
--cc=khoroshilov@ispras.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=remyoudompheng@gmail.com \
--cc=shraddha.6596@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=vthakkar1994@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®