From: Ludovic Desroches <ludovic.desroches@atmel.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
linux-mmc <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
<pierre.samat@atmel.com>,
Ludovic Desroches <ludovic.desroches@atmel.com>
Subject: Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply
Date: Mon, 9 Nov 2015 11:25:55 +0100 [thread overview]
Message-ID: <20151109102555.GA15706@odux.rfo.atmel.com> (raw)
In-Reply-To: <CAPDyKFpC_mKXei14mdD=AYd6YBU0R4D1R=XWpf7BTgX4JDw24w@mail.gmail.com>
On Mon, Nov 09, 2015 at 10:38:03AM +0100, Ulf Hansson wrote:
> [...]
>
> >> > Is the regulator-gpio usage the right thing to do for vqmmc? In my case it is
> >> > not really driven by a gpio but by a pio from the sdhci device. In the binding,
> >>
> >> What's a "pio"?
> >>
> >> What do you mean by the it's driven from the sdhci device?
> >>
> >
> > Sorry I mean sdhci device from the SoC point of view, I should say
> > controller. So yes the signal is driven by the controller.
> >
> >> Is it the internal HW logic of the sdhci controller that manages the
> >> IO voltage? And this logic can be controlled via certain register bits
> >> in the SDHCI controller?
> >>
> >
> > Yes, it depends of the value of the '1.8V Signaling Enable' value in the
> > host control 2 register.
> >
> >> > declaring the gpio is an option so I thought using this regulator fits my need.
> >>
> >> In quite many cases it makes sense to model this though a gpio
> >> regulator. For example when you use a level shifter circuit. Those
> >> normally have gpio pin routed to control the voltage level output for
> >> the signals. For example switching between 1.8V and 2.9V.
> >>
> >
> > I agree, my concern is to know if I can consider it as a 'general' pio
> > since it is driven by the sdhci controller.
>
> This doesn't seems like a case where a gpio regulator should be used
> and I am not sure what problem it would solve. Beside to suppress the
> log warnings (actually those aren't warnings but informations).
>
> Isn't sdhci_do_start_signal_voltage_switch() doing what you need here?
>
It is. I am only wondering the best way to describe the hardware:
- No regulator but I have the 'no vqmmc regulator not found' message which
is a bit annoying and which can be interpreted as an issue for someone
who has no knowledge about this stuff.
- Describe the regulator since there is one on my board. But it is not a
fixed regulator and even if it's close to a gpio one it is not.
Regards
Ludovic
next prev parent reply other threads:[~2015-11-09 10:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 15:59 Ludovic Desroches
2015-11-06 15:59 ` [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power Ludovic Desroches
2015-11-09 13:23 ` Ludovic Desroches
2015-11-09 14:12 ` Ulf Hansson
2015-11-09 14:40 ` Ludovic Desroches
2015-11-09 16:00 ` Ulf Hansson
2015-11-09 16:30 ` Ludovic Desroches
2015-11-24 9:23 ` Ludovic Desroches
2015-11-24 11:01 ` Ulf Hansson
2015-11-24 13:12 ` Ludovic Desroches
2015-11-24 13:56 ` Ulf Hansson
2015-11-24 14:08 ` Ludovic Desroches
2015-11-24 15:17 ` Ulf Hansson
2015-11-06 15:59 ` [PATCH 2/2] ARM: at91/dt: sama5d2 Xplained: add regulators for sdhci devices Ludovic Desroches
2015-11-06 16:42 ` [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply Ulf Hansson
2015-11-09 7:41 ` Ludovic Desroches
2015-11-09 9:38 ` Ulf Hansson
2015-11-09 10:25 ` Ludovic Desroches [this message]
2015-11-09 10:50 ` Ulf Hansson
2015-11-09 13:14 ` Ludovic Desroches
2015-11-09 13:18 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151109102555.GA15706@odux.rfo.atmel.com \
--to=ludovic.desroches@atmel.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=pierre.samat@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®