From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751974AbbKINbY (ORCPT ); Mon, 9 Nov 2015 08:31:24 -0500 Received: from mail-pa0-f47.google.com ([209.85.220.47]:36759 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751473AbbKINbX (ORCPT ); Mon, 9 Nov 2015 08:31:23 -0500 Date: Mon, 9 Nov 2015 19:01:13 +0530 From: Sudip Mukherjee To: Lee Jones Cc: Linus Torvalds , Linux Kernel Mailing List Subject: Re: [GIT PULL] MFD for v4.4 Message-ID: <20151109133113.GA9327@sudip-pc> References: <20151106080421.GA3378@x1> <20151107124230.GF3378@x1> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20151107124230.GF3378@x1> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 07, 2015 at 12:42:30PM +0000, Lee Jones wrote: > On Fri, 06 Nov 2015, Linus Torvalds wrote: > > > On Fri, Nov 6, 2015 at 12:04 AM, Lee Jones wrote: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git tags/mfd-for-linus-4.4 > > > > Ugh. > > > > Maintainers, *please* check new warnings you introduce. We don't have > > that many compiler warnings in the kernel, you shouldn't be > > introducing new ones and not notice. > > > > This pull request introduces this silly new warning: > > > > drivers/mfd/rtsx_pcr.c: In function ‘rtsx_pci_set_pull_ctl’: > > drivers/mfd/rtsx_pcr.c:565:6: warning: unused variable ‘err’ > > [-Wunused-variable] > > int err; > > ^ > > > > due to commit b158b69a3765 ("mfd: rtsx: Simplify function return > > logic") that removes the actual use of the variable, but not the > > variable itself. > > I thought these were cleaned up. Apologies for that. Yes, Fix was submitted. https://lkml.org/lkml/2015/10/7/301 I even got your applied message. (https://lkml.org/lkml/2015/10/13/149) regards sudip