From: Eric B Munson <emunson@akamai.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Thierry Reding <treding@nvidia.com>,
Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuahkh@osg.samsung.com>,
linux-api@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] selftests/mlock2: Add missing #define _GNU_SOURCE
Date: Mon, 9 Nov 2015 10:50:13 -0500 [thread overview]
Message-ID: <20151109155013.GB28486@akamai.com> (raw)
In-Reply-To: <1447064069-21469-2-git-send-email-geert@linux-m68k.org>
[-- Attachment #1: Type: text/plain, Size: 902 bytes --]
On Mon, 09 Nov 2015, Geert Uytterhoeven wrote:
> On glibc 2.3.6:
>
> mlock2-tests.c: In function 'seek_to_smaps_entry':
> mlock2-tests.c:158: warning: implicit declaration of function 'getline'
>
> According to the manpage of getline(), it needs _GNU_SOURCE before glibc
> 2.10.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Eric B Munson <emunson@akamai.com>
> ---
> tools/testing/selftests/vm/mlock2-tests.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/vm/mlock2-tests.c b/tools/testing/selftests/vm/mlock2-tests.c
> index 4431994aade2ef6f..cb247219f1f72889 100644
> --- a/tools/testing/selftests/vm/mlock2-tests.c
> +++ b/tools/testing/selftests/vm/mlock2-tests.c
> @@ -1,3 +1,4 @@
> +#define _GNU_SOURCE
> #include <sys/mman.h>
> #include <stdint.h>
> #include <stdio.h>
> --
> 1.9.1
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-11-09 16:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-09 10:14 [PATCH 0/2] selftests/mlock2: Build warning fixes on Debian/m68k 4.0 Geert Uytterhoeven
2015-11-09 10:14 ` [PATCH 1/2] selftests/mlock2: Add missing #define _GNU_SOURCE Geert Uytterhoeven
2015-11-09 15:50 ` Eric B Munson [this message]
2015-11-09 10:14 ` [PATCH 2/2] selftests/mlock2: Add ULL prefix to 64-bit constants Geert Uytterhoeven
2015-11-09 15:50 ` Eric B Munson
2015-11-09 15:48 ` [PATCH 0/2] selftests/mlock2: Build warning fixes on Debian/m68k 4.0 Eric B Munson
2015-11-09 16:16 ` Eric B Munson
2015-11-09 20:43 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151109155013.GB28486@akamai.com \
--to=emunson@akamai.com \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shuahkh@osg.samsung.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®