From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ranjith <ranjithece24@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
abbotti@mev.co.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] comedi: me_daq: Fix coding style - use BIT macro
Date: Mon, 9 Nov 2015 20:27:53 +0300 [thread overview]
Message-ID: <20151109172752.GV18797@mwanda> (raw)
In-Reply-To: <1447089236-14389-1-git-send-email-ranjithece24@gmail.com>
On Mon, Nov 09, 2015 at 10:43:56PM +0530, Ranjith wrote:
> +#define ADC_GAIN_2 (BIT(5) & (~BIT(4)))
It looks really weird to write it this way...
regards,
dan carpenter
prev parent reply other threads:[~2015-11-09 17:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-09 17:13 Ranjith
2015-11-09 17:13 ` Hartley Sweeten
2015-11-09 17:27 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151109172752.GV18797@mwanda \
--to=dan.carpenter@oracle.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ranjithece24@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®