From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751811AbbKJVGU (ORCPT ); Tue, 10 Nov 2015 16:06:20 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:34679 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751131AbbKJVGS convert rfc822-to-8bit (ORCPT ); Tue, 10 Nov 2015 16:06:18 -0500 Date: Tue, 10 Nov 2015 16:06:15 -0500 (EST) Message-Id: <20151110.160615.1511568572619688788.davem@davemloft.net> To: mans@mansr.com Cc: eric.dumazet@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, slash.tmp@free.fr Subject: Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller From: David Miller In-Reply-To: References: <20151110.150403.1195107307226924000.davem@davemloft.net> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 10 Nov 2015 13:06:18 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Måns Rullgård Date: Tue, 10 Nov 2015 20:53:19 +0000 > David Miller writes: > >> From: Måns Rullgård >> Date: Tue, 10 Nov 2015 18:05:15 +0000 >> >>> Because I haven't been following the netdev list closely for the last >>> five years, and no documentation I read mentioned this function. I can >>> certainly change it. >> >> It is always advisable to mimick what other drivers do and use them as >> a reference, rather than depend upon documentation which by definition >> is always going to be out of sync with the source tree. > > Sure. The trick is to pick the right driver(s) to use as reference. > Quite a few of them don't use that function. If you really are stumped on this matter, start at least with the ixgbe driver. In fact pretty much every Intel ethernet driver is a reasonable reference. Others to check out are bnx2x and mlx5.