From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752668AbbKJShc (ORCPT ); Tue, 10 Nov 2015 13:37:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48766 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751952AbbKJSha (ORCPT ); Tue, 10 Nov 2015 13:37:30 -0500 Date: Tue, 10 Nov 2015 13:37:26 -0500 From: Jessica Yu To: Josh Poimboeuf Cc: Jiri Slaby , Rusty Russell , Seth Jennings , Jiri Kosina , Vojtech Pavlik , Miroslav Benes , linux-api@vger.kernel.org, live-patching@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: samples: livepatch: init reloc list and mark as klp module Message-ID: <20151110183725.GA22400@packer-debian-8-amd64.digitalocean.com> References: <1447130755-17383-1-git-send-email-jeyu@redhat.com> <1447130755-17383-5-git-send-email-jeyu@redhat.com> <5641A7BA.8000100@suse.cz> <20151110135006.GB3163@treble.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20151110135006.GB3163@treble.redhat.com> X-OS: Linux eisen.io 3.16.0-4-amd64 x86_64 User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +++ Josh Poimboeuf [10/11/15 07:50 -0600]: >On Tue, Nov 10, 2015 at 09:15:54AM +0100, Jiri Slaby wrote: >> On 11/10/2015, 05:45 AM, Jessica Yu wrote: >> > Intialize the list of relocation sections in the sample >> > klp_object (even if the list will be empty in this case). >> > Also mark module as a livepatch module so that the module >> > loader can appropriately initialize it. >> > >> > Signed-off-by: Jessica Yu >> > --- >> > samples/livepatch/livepatch-sample.c | 2 ++ >> > 1 file changed, 2 insertions(+) >> > >> > diff --git a/samples/livepatch/livepatch-sample.c b/samples/livepatch/livepatch-sample.c >> > index fb8c861..2ef9345 100644 >> > --- a/samples/livepatch/livepatch-sample.c >> > +++ b/samples/livepatch/livepatch-sample.c >> > @@ -57,6 +57,7 @@ static struct klp_object objs[] = { >> > { >> > /* name being NULL means vmlinux */ >> > .funcs = funcs, >> > + .reloc_secs = LIST_HEAD_INIT(objs[0].reloc_secs) >> >> And I see now. This is not the best place for it though. I would put >> INIT_LIST_HEAD in the core code instead. > >Maybe the reloc_secs list should instead be an array of klp_reloc_sec >structs, with the last entry being 0, similar to how we do other "lists" >in the klp interface (e.g., klp_patch.objs, klp_object.funcs). Yeah, I admit the asymmetry is a bit awkward. Plus we can add in a klp_for_each_reloc_sec to keep the api consistent. I'll go ahead and change this to follow the existing klp "list" format. Jessica