From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753625AbbKLVMZ (ORCPT ); Thu, 12 Nov 2015 16:12:25 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:47841 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750944AbbKLVMY (ORCPT ); Thu, 12 Nov 2015 16:12:24 -0500 Date: Thu, 12 Nov 2015 16:12:21 -0500 (EST) Message-Id: <20151112.161221.471436899716074817.davem@davemloft.net> To: arnd@arndb.de Cc: linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, mathieu@codeaurora.org, linux-kernel@vger.kernel.org, peppe.cavallaro@st.com Subject: Re: [PATCH v2] stmmac: avoid ipq806x constant overflow warning From: David Miller In-Reply-To: <3825178.3luTQFAgny@wuerfel> References: <20151112.122528.1794206832971213176.davem@davemloft.net> <3729464.5X0HBxzvx5@wuerfel> <3825178.3luTQFAgny@wuerfel> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 12 Nov 2015 13:12:23 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Thu, 12 Nov 2015 22:03:40 +0100 > @@ -337,11 +337,11 @@ static int ipq806x_gmac_probe(struct platform_device *pdev) > QSGMII_PHY_RX_SIGNAL_DETECT_EN | > QSGMII_PHY_TX_DRIVER_EN | > QSGMII_PHY_QSGMII_EN | > - 0x4 << QSGMII_PHY_PHASE_LOOP_GAIN_OFFSET | > - 0x3 << QSGMII_PHY_RX_DC_BIAS_OFFSET | > - 0x1 << QSGMII_PHY_RX_INPUT_EQU_OFFSET | > - 0x2 << QSGMII_PHY_CDR_PI_SLEW_OFFSET | > - 0xC << QSGMII_PHY_TX_DRV_AMP_OFFSET); > + 0x4ul << QSGMII_PHY_PHASE_LOOP_GAIN_OFFSET | > + 0x3ul << QSGMII_PHY_RX_DC_BIAS_OFFSET | > + 0x1ul << QSGMII_PHY_RX_INPUT_EQU_OFFSET | > + 0x2ul << QSGMII_PHY_CDR_PI_SLEW_OFFSET | > + 0xCul << QSGMII_PHY_TX_DRV_AMP_OFFSET); > } > Indeed, this looks so much better. Applied. Thanks for looking more deeply into this!