From: Byungchul Park <byungchul.park@lge.com>
To: mingo@kernel.org, peterz@infradead.org
Cc: linux-kernel@vger.kernel.org, efault@gmx.de, tglx@linutronix.de,
fweisbec@gmail.com
Subject: Re: [PATCH v5 0/2] sched: consider missed ticks when updating cpu load
Date: Thu, 12 Nov 2015 15:59:32 +0900 [thread overview]
Message-ID: <20151112065932.GG7136@byungchulpark-X58A-UD3R> (raw)
In-Reply-To: <20151111093810.GB7136@byungchulpark-X58A-UD3R>
On Wed, Nov 11, 2015 at 06:38:10PM +0900, Byungchul Park wrote:
> On Tue, Nov 10, 2015 at 09:36:00AM +0900, byungchul.park@lge.com wrote:
> > From: Byungchul Park <byungchul.park@lge.com>
> >
> > change from v4 to v5
> > - fix comments and commit message
> > - take new_load into account in update_cpu_load_nohz() and __update_cpu_load()
> > because it's non-zero in NOHZ_FULL
> >
> > change from v3 to v4
> > - focus the problem on full NOHZ
> >
> > change from v2 to v3
> > - add a patch which make __update_cpu_load() handle active tickless
> >
> > change from v1 to v2
> > - add some additional commit message (logic is same exactly)
> >
> > additionally i tried to use the return value of hrtimer_forward() instead of
> > jiffies to get pending tick for updating cpu load. it's easy for
> > update_cpu_load_nohz() to do that. but for update_idle_cpu_load(), i need
> > more time to think about how to implement it nicely.
>
> Actually because of update_idle_load() which is used when doing nohz
> load balancing while the cpu has been still tick-stopped, this looks
> not be able to be implemented without any kind of last_update_xxx
^^^
last_load_update_tick
> variable. What do you think about it, Peter?
>
> >
> > and i will try to fix other stuffs caused by full NOHZ later with another
> > patch. i decided to send this patch at first because "cpu load update" is a
> > standalone problem which is not coupled with other stuffs.
> >
> > Byungchul Park (2):
> > sched: make __update_cpu_load() handle NOHZ_FULL tickless
> > sched: make update_cpu_load_nohz() consider missed ticks in NOHZ_FULL
> >
> > include/linux/sched.h | 4 ++--
> > kernel/sched/fair.c | 57 +++++++++++++++++++++++++++++++++++++---------
> > kernel/time/tick-sched.c | 8 +++----
> > 3 files changed, 52 insertions(+), 17 deletions(-)
> >
> > --
> > 1.7.9.5
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2015-11-12 6:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 0:36 byungchul.park
2015-11-10 0:36 ` [PATCH v5 1/2] sched: make __update_cpu_load() handle NOHZ_FULL tickless byungchul.park
2015-11-10 0:36 ` [PATCH v5 2/2] sched: make update_cpu_load_nohz() consider missed ticks in NOHZ_FULL byungchul.park
2015-11-11 9:42 ` Byungchul Park
2015-11-20 13:19 ` Peter Zijlstra
2015-11-23 2:32 ` Byungchul Park
2015-11-23 16:19 ` [tip:sched/core] sched/fair: Consider missed ticks in NOHZ_FULL in update_cpu_load_nohz() tip-bot for Byungchul Park
2015-11-11 9:38 ` [PATCH v5 0/2] sched: consider missed ticks when updating cpu load Byungchul Park
2015-11-12 6:59 ` Byungchul Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151112065932.GG7136@byungchulpark-X58A-UD3R \
--to=byungchul.park@lge.com \
--cc=efault@gmx.de \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®