From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753837AbbKLIxa (ORCPT ); Thu, 12 Nov 2015 03:53:30 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:45978 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753793AbbKLIx2 (ORCPT ); Thu, 12 Nov 2015 03:53:28 -0500 Date: Thu, 12 Nov 2015 00:53:27 -0800 From: Christoph Hellwig To: Matias Bj??rling Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, axboe@fb.com Subject: Re: [PATCH] null_blk: Register as a LightNVM device Message-ID: <20151112085327.GA28149@infradead.org> References: <1447236398-9421-1-git-send-email-m@bjorling.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447236398-9421-1-git-send-email-m@bjorling.me> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 11, 2015 at 11:06:38AM +0100, Matias Bj??rling wrote: > Add support for registering as a LightNVM device. This allows us to > evaluate the performance of the LightNVM library. > > In /drivers/Makefile, LightNVM is moved above block device drivers > to make sure that the LightNVM media managers have been initialized > before drivers under /drivers/block are initialized. I don't think mixing the lighnvm code into null_blk is a good idea. Please just create a separate null_nvm device for lighnvm. It already has a completely separate I/O path.