mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Eduardo Valentin <edubezval@gmail.com>
Cc: Caesar Wang <wxt@rock-chips.com>,
	rui.zhang@intel.com, heiko@sntech.de,
	linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
	linux-pm@vger.kernel.org, lkp@intel.com
Subject: Re: [PATCH] thermal: rockchip: fix compile error
Date: Thu, 12 Nov 2015 09:06:58 +1100	[thread overview]
Message-ID: <20151112090658.619c3b7c@canb.auug.org.au> (raw)
In-Reply-To: <20151109193638.GB10824@localhost.localdomain>

Hi Eduardo,

On Mon, 9 Nov 2015 11:36:39 -0800 Eduardo Valentin <edubezval@gmail.com> wrote:
>
> On Sun, Nov 08, 2015 at 09:40:43PM +0800, Caesar Wang wrote:
> > Missing a include file caused compile error.
> > 
> > drivers/thermal/rockchip_thermal.c:
> > In function 'rockchip_thermal_suspend':
> > drivers/thermal/rockchip_thermal.c:720:2: error: implicit
> > declaration of function 'pinctrl_pm_select_sleep_state'
> > [-Werror=implicit-function-declaration]
> > pinctrl_pm_select_sleep_state(dev);
> >                  ^
> > drivers/thermal/rockchip_thermal.c:
> > In function 'rockchip_thermal_resume':
> > drivers/thermal/rockchip_thermal.c:759:2: error: implicit
> > declaration of function 'pinctrl_pm_select_default_state'
> > [-Werror=implicit-function-declaration]
> > ^pinctrl_pm_select_default_state(dev);
> > cc1: some warnings being treated as errors
> > 
> > Fixes: 7e38a5b1daa1 ("thermal: rockchip: support the sleep pinctrl state
> > to avoid glitches")  
> 
> 
> Adding this to my tree and sending to ruis too.

This missed the merge of the thermal tree into Linus' tree and so is
now needed in Linus' tree ASAP (several builds are failing).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

  reply	other threads:[~2015-11-11 22:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-08 13:40 Caesar Wang
2015-11-09 19:36 ` Eduardo Valentin
2015-11-11 22:06   ` Stephen Rothwell [this message]
2015-11-12  3:32     ` Eduardo Valentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151112090658.619c3b7c@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=edubezval@gmail.com \
    --cc=heiko@sntech.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=lkp@intel.com \
    --cc=rui.zhang@intel.com \
    --cc=wxt@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®