mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, acme@redhat.com, mingo@elte.hu,
	ak@linux.intel.com, edumazet@google.com
Subject: Re: [PATCH v3 0/2] perf/core: rcu fixes
Date: Thu, 12 Nov 2015 11:32:03 +0100	[thread overview]
Message-ID: <20151112103203.GX17308@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1447322404-10920-1-git-send-email-eranian@google.com>

On Thu, Nov 12, 2015 at 11:00:02AM +0100, Stephane Eranian wrote:
> 
> This short patch series fixes some issues with RCU locking in the generic
> perf layer.
> 
> Patch 1 fixes cgroup switching rcu issues related to the fact that
> perf_cgroup_sched_out() and perf_cgroup_sched_in() were missing some
> rcu read lock to protect the reference to the cgroup. Consequently,
> we moved the rcu readlock out of perf_cgroup_switch() to avoid double
> calls.
> 
> Patch 2 reinforces the testing for the rcu locking in perf cgorup code.
> Either we have to hold the rcu read lock or we must have the ctx->lock
> which guarantees the task cannot leave the cgroup.
> 
> Thanks to Peter and Eric from their suggestions on how to fix this correctly.
> 
> Stephane Eranian (2):
>   perf/core: fix RCU problem with cgroup context switching code
>   perf/core: robustify perf_cgroup_from_task rcu checks

Thanks!

      parent reply	other threads:[~2015-11-12 10:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-12 10:00 Stephane Eranian
2015-11-12 10:00 ` [PATCH v3 1/2] perf/core: fix RCU problem with cgroup context switching code Stephane Eranian
2015-11-23 16:16   ` [tip:perf/core] perf/core: Fix " tip-bot for Stephane Eranian
2015-11-12 10:00 ` [PATCH v3 2/2] perf/core: robustify perf_cgroup_from_task rcu checks Stephane Eranian
2015-11-23 16:17   ` [tip:perf/core] perf/core: Robustify the perf_cgroup_from_task() RCU checks tip-bot for Stephane Eranian
2015-11-12 10:32 ` Peter Zijlstra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151112103203.GX17308@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=acme@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=edumazet@google.com \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®