From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754856AbbKLPtT (ORCPT ); Thu, 12 Nov 2015 10:49:19 -0500 Received: from smtprelay0061.hostedemail.com ([216.40.44.61]:60134 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751241AbbKLPtQ (ORCPT ); Thu, 12 Nov 2015 10:49:16 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::,RULES_HIT:41:334:355:368:369:379:541:599:800:960:988:989:1260:1277:1311:1313:1314:1345:1359:1431:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2551:2553:2559:2562:2692:2736:3138:3139:3140:3141:3142:3353:3622:3865:3867:3868:3870:3871:3872:3873:3874:4362:4605:5007:6119:6261:7875:7904:9707:10004:10400:10848:10967:11026:11232:11473:11658:11914:12050:12296:12517:12519:12740:13069:13161:13229:13311:13357:14096:14097:14659:21080:21088:30012:30054:30089:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: home40_3391c674cc11f X-Filterd-Recvd-Size: 2310 Date: Thu, 12 Nov 2015 10:49:13 -0500 From: Steven Rostedt To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, Peter Zijlstra , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH] sched/rt: hide push_irq_work_func declaration Message-ID: <20151112104913.4f68a92c@gandalf.local.home> In-Reply-To: <4129441.9nXLnMzV6v@wuerfel> References: <3810009.VdDTV0h1Qp@wuerfel> <20151112094739.0168e191@gandalf.local.home> <4129441.9nXLnMzV6v@wuerfel> X-Mailer: Claws Mail 3.13.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 12 Nov 2015 16:14:06 +0100 Arnd Bergmann wrote: > On Thursday 12 November 2015 09:47:39 Steven Rostedt wrote: > > > -#ifdef CONFIG_SMP > > > +#if IS_ENABLED(CONFIG_SMP) && defined(HAVE_RT_PUSH_IPI) > > > > Why IS_ENABLED() and not defined()? > > > > #if defined(CONFIG_SMP) && defined(HAVE_RT_PUSH_IPI) > > > > I thought IS_ENABLED() is used for C code, like: > > > > if (IS_ENABLED(CONFIG_SMP)) { > > [...] > > } > > "#if IS_ENABLED(CONFIG_foo)" has another property, which is > to evaluate to true when Kconfig has set the symbol to "=m". > Obviously that cannot happen for CONFIG_SMP, but some > maintainers prefer using IS_ENABLED() consistently for all > config symbols. > > I don't care much either way, and it's easily changed if > we still want the patch and you prefer a plain #if defined(). > For this instance, I do prefer the "defined()" version. I can understand the IS_ENABLED() for module configs. But I don't see the need to make all #if's use it. Maybe because I don't deal with module configs much. Anyway, this patch should probably go in now as a current "fix", and the redesign should be looked at as well, but that's unrelated to your arch, and you shouldn't need to worry about it. Thanks, -- Steve