From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754865AbbKLPwc (ORCPT ); Thu, 12 Nov 2015 10:52:32 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:39604 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752324AbbKLPwb (ORCPT ); Thu, 12 Nov 2015 10:52:31 -0500 Date: Thu, 12 Nov 2015 07:52:30 -0800 From: Christoph Hellwig To: Jens Axboe Cc: Christoph Hellwig , Matias Bj??rling , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, axboe@fb.com Subject: Re: [PATCH] null_blk: Register as a LightNVM device Message-ID: <20151112155230.GA30642@infradead.org> References: <1447236398-9421-1-git-send-email-m@bjorling.me> <20151112085327.GA28149@infradead.org> <5644B4F4.5090805@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5644B4F4.5090805@kernel.dk> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 12, 2015 at 08:49:08AM -0700, Jens Axboe wrote: > But it still avoids duplicating the generics of it. Patch for null_blk: > > 3 files changed, 168 insertions(+), 7 deletions (-) > > vs a standalone of: > > 3 files changed, 459 insertions(+) > > It doesn't screw up null_blk, so I'd prefer just adding it as an on-the-side > mode for that. 300 lines of boilerplate for just setting up a few request_queues seem wrong, can you show the actual patch you measured?