From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752576AbbKPUJE (ORCPT ); Mon, 16 Nov 2015 15:09:04 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:40803 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751451AbbKPUJC (ORCPT ); Mon, 16 Nov 2015 15:09:02 -0500 Date: Mon, 16 Nov 2015 15:09:00 -0500 (EST) Message-Id: <20151116.150900.193988253386004564.davem@davemloft.net> To: Ben@Benjojo.co.uk Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, ben+patches@Benjojo.co.uk Subject: Re: [PATCH v2 net] raw: increment correct SNMP counters for ICMP messages From: David Miller In-Reply-To: <20151114151358.GA11387@benjojo.co.uk> References: <20151114151358.GA11387@benjojo.co.uk> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 16 Nov 2015 12:09:02 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ben Cartwright-Cox Date: Sat, 14 Nov 2015 15:13:58 +0000 > Sending ICMP packets with raw sockets ends up in the SNMP counters > logging the type as the first byte of the IPv4 header rather than > the ICMP header. This is fixed by adding the IP Header Length to > the casting into a icmphdr struct. > > Signed-off-by: Ben Cartwright-Cox > Acked-by: Eric Dumazet Applied.