From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752849AbbKPQZP (ORCPT ); Mon, 16 Nov 2015 11:25:15 -0500 Received: from smtprelay0081.hostedemail.com ([216.40.44.81]:48943 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752151AbbKPQZM (ORCPT ); Mon, 16 Nov 2015 11:25:12 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1538:1593:1594:1711:1714:1730:1747:1777:1792:2393:2553:2559:2562:2693:3138:3139:3140:3141:3142:3350:3622:3865:3868:3871:3874:5007:6261:7875:9010:10004:10400:10848:10967:11026:11232:11473:11658:11914:12296:12438:12517:12519:12740:13069:13161:13229:13311:13357:14659:21080:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: mine25_fe4ce83a1322 X-Filterd-Recvd-Size: 1565 Date: Mon, 16 Nov 2015 11:25:08 -0500 From: Steven Rostedt To: Namhyung Kim Cc: x86@kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , LKML Subject: Re: [PATCH] ftrace/x86: Fix missing ops arg on static function tracing Message-ID: <20151116112508.6e6f3a5d@gandalf.local.home> In-Reply-To: <20151116105453.3de46887@gandalf.local.home> References: <1447493548-31978-1-git-send-email-namhyung@kernel.org> <20151116105453.3de46887@gandalf.local.home> X-Mailer: Claws Mail 3.13.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 16 Nov 2015 10:54:53 -0500 Steven Rostedt wrote: > This isn't needed, nor will the parameter be used if added. A comment > should probably be added here instead. > > /* > * When DYNAMIC_FTRACE is not defined, ARCH_SUPPORTS_FTRACE_OPS is not > * set (see include/asm/ftrace.h). Only the ip and parent ip are used Probably should also add "and include/linux/ftrace.h" as that's where the ARCH_SUPPORTS_FTRACE_OPS is described. -- Steve > * and the list function is called when function tracing is enabled. > */ >