From: Borislav Petkov <bp@alien8.de>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>, x86-ml <x86@kernel.org>,
Andy Lutomirski <luto@amacapital.net>,
Steven Rostedt <rostedt@goodmis.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH -v2.1] x86: Kill notsc
Date: Tue, 17 Nov 2015 09:53:46 +0100 [thread overview]
Message-ID: <20151117085345.GB8819@pd.tnic> (raw)
In-Reply-To: <564AB4D7.20606@zytor.com>
On Mon, Nov 16, 2015 at 09:02:15PM -0800, H. Peter Anvin wrote:
> On 11/16/15 13:25, Thomas Gleixner wrote:
> > On Mon, 16 Nov 2015, Borislav Petkov wrote:
> >> -/*
> >> - * disable flag for tsc. Takes effect by clearing the TSC cpu flag
> >> - * in cpu/common.c
> >> - */
> >> -int __init notsc_setup(char *str)
> >> +/* Disable the TSC feature flag to avoid further TSC use. */
> >> +int __init notsc_setup(void)
> >> {
> >> +#ifndef CONFIG_X86_TSC
> >> setup_clear_cpu_cap(X86_FEATURE_TSC);
> >
> > This is silly, really.
> >
> > If CONFIG_X86_TSC is disabled then we should just not compile tsc.c at
> > all and map cpu_has_tsc and stuff depending on it to false.
> >
>
> CONFIG_X86_TSC means TSC is obligatory, not that it is supported.
Hmm, I'd still need to untangle tsc.c though for people who want to
disable it for whatever reason.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
next prev parent reply other threads:[~2015-11-17 8:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-18 14:20 [RFC PATCH] " Borislav Petkov
2015-10-19 4:47 ` Andy Lutomirski
2015-10-19 8:16 ` Borislav Petkov
2015-10-21 17:58 ` Borislav Petkov
2015-10-21 19:01 ` Peter Zijlstra
2015-10-22 18:51 ` [PATCH -v2] " Borislav Petkov
2015-11-04 10:21 ` Thomas Gleixner
2015-11-04 10:29 ` Borislav Petkov
2015-11-16 18:45 ` [RFC PATCH -v2.1] " Borislav Petkov
2015-11-16 21:25 ` Thomas Gleixner
2015-11-17 5:02 ` H. Peter Anvin
2015-11-17 8:53 ` Borislav Petkov [this message]
2015-11-17 9:11 ` Thomas Gleixner
2015-11-17 9:33 ` Borislav Petkov
2015-11-17 10:08 ` Thomas Gleixner
2015-11-17 11:09 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151117085345.GB8819@pd.tnic \
--to=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®