mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serge@hallyn.com>
To: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
Cc: james.l.morris@oracle.com, serge@hallyn.com,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] security: remove unused cap_is_fs_cap function
Date: Tue, 17 Nov 2015 11:27:17 -0600	[thread overview]
Message-ID: <20151117172717.GA11708@mail.hallyn.com> (raw)
In-Reply-To: <1447745124-8580-1-git-send-email-baiyaowei@cmss.chinamobile.com>

On Tue, Nov 17, 2015 at 03:25:23PM +0800, Yaowei Bai wrote:
> Since commit 3bc1fa8a ("LSM: remove BSD secure level security module")
> there is no user of cap_is_fs_cap any more, so remove it.
> 
> Signed-off-by: Yaowei Bai <baiyaowei@cmss.chinamobile.com>

Acked-by: Serge Hallyn <serge.hallyn@canonical.com>

> ---
>  include/linux/capability.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/include/linux/capability.h b/include/linux/capability.h
> index af9f0b9..b032003 100644
> --- a/include/linux/capability.h
> +++ b/include/linux/capability.h
> @@ -171,12 +171,6 @@ static inline int cap_issubset(const kernel_cap_t a, const kernel_cap_t set)
>  
>  /* Used to decide between falling back on the old suser() or fsuser(). */
>  
> -static inline int cap_is_fs_cap(int cap)
> -{
> -	const kernel_cap_t __cap_fs_set = CAP_FS_SET;
> -	return !!(CAP_TO_MASK(cap) & __cap_fs_set.cap[CAP_TO_INDEX(cap)]);
> -}
> -
>  static inline kernel_cap_t cap_drop_fs_set(const kernel_cap_t a)
>  {
>  	const kernel_cap_t __cap_fs_set = CAP_FS_SET;
> -- 
> 1.9.1
> 
> 

  parent reply	other threads:[~2015-11-17 17:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-17  7:25 Yaowei Bai
2015-11-17  7:25 ` [PATCH 2/2] security/capability.h: cap_issubset/isclear can be boolean Yaowei Bai
2015-11-17 17:35   ` Serge E. Hallyn
2015-11-17 23:57   ` James Morris
2015-11-17 17:27 ` Serge E. Hallyn [this message]
2015-11-17 23:57 ` [PATCH 1/2] security: remove unused cap_is_fs_cap function James Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151117172717.GA11708@mail.hallyn.com \
    --to=serge@hallyn.com \
    --cc=baiyaowei@cmss.chinamobile.com \
    --cc=james.l.morris@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®