mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Cory Tusar <cory.tusar@pid1solutions.com>
Cc: pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	agust@denx.de, gregkh@linuxfoundation.org, jic23@kernel.org,
	vz@mleia.com, broonie@kernel.org, afd@ti.com, andrew@lunn.ch,
	Chris.Healy@zii.aero, Keith.Vennel@zii.aero,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/7] misc: eeprom: 93xx46: Add DT binding for a GPIO 'select' line.
Date: Tue, 17 Nov 2015 14:59:01 -0600	[thread overview]
Message-ID: <20151117205901.GA10669@rob-hp-laptop> (raw)
In-Reply-To: <1447733796-15546-7-git-send-email-cory.tusar@pid1solutions.com>

On Mon, Nov 16, 2015 at 11:16:35PM -0500, Cory Tusar wrote:
> This commit documents an additional devicetree binding in the
> eeprom_93x46 driver allowing a GPIO line to function as a 'select'
> or 'enable' signal prior to accessing the EEPROM.

You can just fold all the DT binding patches into 1. They don't have to 
match up to driver changes.

> 
> Signed-off-by: Cory Tusar <cory.tusar@pid1solutions.com>
> ---
>  Documentation/devicetree/bindings/misc/eeprom-93xx46.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt b/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt
> index 34a0cc2..75b16f4 100644
> --- a/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt
> +++ b/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt
> @@ -6,6 +6,8 @@ Required properties:
>  
>  Optional properties:
>  - read-only : parameter-less property which disables writes to the EEPROM
> +- select-gpio : if present, specifies the GPIO that will be asserted prior to
> +  each access to the EEPROM (e.g. for SPI bus multiplexing)

This should be "select-gpios".

>  
>  Property rules described in Documentation/devicetree/bindings/spi/spi-bus.txt
>  apply.  In particular, "reg" and "spi-max-frequency" properties must be given.
> @@ -17,4 +19,5 @@ Example:
>  		spi-max-frequency = <1000000>;
>  		spi-cs-high;
>  		data-size = <8>;
> +		select-gpio = <&gpio4 4 GPIO_ACTIVE_HIGH>;
>  	};
> -- 
> 2.4.10
> 

  reply	other threads:[~2015-11-17 20:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-17  4:16 [PATCH 0/7] Devicetree support for misc/eeprom/eeprom_93xx46 Cory Tusar
2015-11-17  4:16 ` [PATCH 1/7] misc: eeprom: 93xx46: Fix 16-bit read and write accesses Cory Tusar
2015-11-17  4:16 ` [PATCH 2/7] misc: eeprom: 93xx46: Add DT bindings to eeprom_93xx46 driver Cory Tusar
2015-11-17 20:53   ` Rob Herring
2015-11-17 21:14     ` Cory Tusar
2015-11-17  4:16 ` [PATCH 3/7] misc: eeprom: 93xx46: Implement eeprom_93xx46 DT bindings Cory Tusar
2015-11-17  4:16 ` [PATCH 4/7] misc: eeprom: 93xx46: Add DT binding for Atmel AT93C46D devices Cory Tusar
2015-11-17 20:56   ` Rob Herring
2015-11-17 21:15     ` Cory Tusar
2015-11-17  4:16 ` [PATCH 5/7] misc: eeprom: 93xx46: Add quirks to support Atmel AT93C46D device Cory Tusar
2015-11-17  4:16 ` [PATCH 6/7] misc: eeprom: 93xx46: Add DT binding for a GPIO 'select' line Cory Tusar
2015-11-17 20:59   ` Rob Herring [this message]
2015-11-17 21:19     ` Cory Tusar
2015-11-17  4:16 ` [PATCH 7/7] misc: eeprom: 93xx46: Add support " Cory Tusar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151117205901.GA10669@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=Chris.Healy@zii.aero \
    --cc=Keith.Vennel@zii.aero \
    --cc=afd@ti.com \
    --cc=agust@denx.de \
    --cc=andrew@lunn.ch \
    --cc=broonie@kernel.org \
    --cc=cory.tusar@pid1solutions.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jic23@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=vz@mleia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®