From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933241AbbKRP4k (ORCPT ); Wed, 18 Nov 2015 10:56:40 -0500 Received: from mail-yk0-f172.google.com ([209.85.160.172]:35198 "EHLO mail-yk0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933034AbbKRP4i (ORCPT ); Wed, 18 Nov 2015 10:56:38 -0500 Date: Wed, 18 Nov 2015 10:56:34 -0500 From: Tejun Heo To: Ilya Dryomov Cc: Christoph Hellwig , "linux-kernel@vger.kernel.org" , linux-fsdevel@vger.kernel.org, Ceph Development Subject: Re: request_queue use-after-free - inode_detach_wb() Message-ID: <20151118155634.GB11496@mtj.duckdns.org> References: <20151117205641.GF22864@mtj.duckdns.org> <20151118153039.GA11496@mtj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Ilya. On Wed, Nov 18, 2015 at 04:48:06PM +0100, Ilya Dryomov wrote: > Just to be clear, the bdi/wb vs inode lifetime rules are that inodes > should always be within bdi/wb? There's been a lot of churn in this Yes, that's where *I* think we should be headed. Stuff in lower layers should stick around while upper layer things are around. > and related areas recently, including in block drivers: 6cd18e711dd8 > ("block: destroy bdi before blockdev is unregistered"), b02176f30cd3 > ("block: don't release bdi while request_queue has live references"), > so I want to fully get my head around this. End-of-life issue has always been a bit of mess in the block layer. Thanks a lot for working on this. -- tejun