From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757487AbbKSA4F (ORCPT ); Wed, 18 Nov 2015 19:56:05 -0500 Received: from violet.fr.zoreil.com ([92.243.8.30]:55849 "EHLO violet.fr.zoreil.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753511AbbKSA4D (ORCPT ); Wed, 18 Nov 2015 19:56:03 -0500 Date: Thu, 19 Nov 2015 01:55:56 +0100 From: Francois Romieu To: Ondrej Zary Cc: netdev@vger.kernel.org, David Miller , Kernel development list Subject: Re: [PATCH 3/3 v2] dl2k: Implement suspend Message-ID: <20151119005556.GA4882@electric-eye.fr.zoreil.com> References: <1447882589-11264-1-git-send-email-linux@rainbow-software.org> <1447882589-11264-3-git-send-email-linux@rainbow-software.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447882589-11264-3-git-send-email-linux@rainbow-software.org> X-Organisation: Land of Sunshine Inc. User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ondrej Zary : [...] > diff --git a/drivers/net/ethernet/dlink/dl2k.c b/drivers/net/ethernet/dlink/dl2k.c > index 9e9baa0..28a96d3 100644 > --- a/drivers/net/ethernet/dlink/dl2k.c > +++ b/drivers/net/ethernet/dlink/dl2k.c [...] > @@ -1824,11 +1831,55 @@ rio_remove1 (struct pci_dev *pdev) > } > } > > +#ifdef CONFIG_PM_SLEEP > +static int rio_suspend(struct device *device) > +{ > + struct net_device *dev = dev_get_drvdata(device); > + struct netdev_private *np = netdev_priv(dev); > + > + if (!netif_running(dev)) > + return 0; > + > + netif_device_detach(dev); > + del_timer_sync(&np->timer); > + rio_hw_stop(dev); > + > + return 0; > +} > + > +static int rio_resume(struct device *device) > +{ > + struct net_device *dev = dev_get_drvdata(device); > + struct netdev_private *np = netdev_priv(dev); > + > + if (!netif_running(dev)) > + return 0; > + > + rio_reset_ring(np); Almost. You should give the Rx/Tx descriptor 'status' word some love. -- Ueimor