From: Ingo Molnar <mingo@kernel.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Chris Wilson <chris@chris-wilson.co.uk>,
Chuck Ebbert <cebbert.lkml@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Tejun Heo <tj@kernel.org>, Rusty Russell <rusty@rustcorp.com.au>,
Peter Zijlstra <peterz@infradead.org>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Jiri Kosina <jkosina@suse.cz>,
"H. Peter Anvin" <hpa@linux.intel.com>,
Steven Rostedt <rostedt@goodmis.org>,
Jason Baron <jbaron@akamai.com>,
yrl.pp-manager.tt@hitachi.com, Borislav Petkov <bpetkov@suse.de>,
Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: i915.ko WC writes are slow after ea8596bb2d8d379
Date: Thu, 19 Nov 2015 09:14:23 +0100 [thread overview]
Message-ID: <20151119081423.GB16214@gmail.com> (raw)
In-Reply-To: <CALCETrWs2vzFWOFs8vV98OfJTa2=BOwGapuKgsrE7ci8whMgHg@mail.gmail.com>
* Andy Lutomirski <luto@amacapital.net> wrote:
> On Wed, Nov 18, 2015 at 6:48 AM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > Although
> >
> > diff --git a/include/linux/stop_machine.h b/include/linux/stop_machine.h
> > index d2abbdb..ff4f029 100644
> > --- a/include/linux/stop_machine.h
> > +++ b/include/linux/stop_machine.h
> > @@ -97,7 +97,7 @@ static inline int try_stop_cpus(const struct cpumask *cpumask,
> > * grabbing every spinlock (and more). So the "read" side to such a
> > * lock is anything which disables preemption.
> > */
> > -#if defined(CONFIG_STOP_MACHINE) && defined(CONFIG_SMP)
> > +#if defined(CONFIG_SMP) || defined(CONFIG_HOTPLUG_CPU)
>
> [...]
>
> This seems much better. Having a set of stop_machine functions around
> that don't work depending on config seems dangerous.
Agreed.
Acked-by: Ingo Molnar <mingo@kernel.org>
Thanks,
Ingo
next prev parent reply other threads:[~2015-11-19 8:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 9:03 Chris Wilson
2014-10-08 10:10 ` Chuck Ebbert
2014-10-08 19:49 ` Chris Wilson
2014-10-08 21:36 ` H. Peter Anvin
2014-10-09 6:53 ` Chris Wilson
2014-10-09 12:44 ` Chuck Ebbert
2014-10-09 13:00 ` Chris Wilson
2014-10-09 14:46 ` Chuck Ebbert
2014-10-09 15:14 ` Chris Wilson
2015-11-18 14:48 ` Chris Wilson
2015-11-18 15:57 ` Andy Lutomirski
2015-11-19 8:14 ` Ingo Molnar [this message]
2015-11-19 10:03 ` [PATCH] kernel: Remove stop_machine() Kconfig dependency Chris Wilson
2015-11-19 8:16 ` i915.ko WC writes are slow after ea8596bb2d8d379 Ingo Molnar
2014-10-08 17:47 ` Chuck Ebbert
2014-10-09 1:45 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151119081423.GB16214@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bpetkov@suse.de \
--cc=cebbert.lkml@gmail.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=hpa@linux.intel.com \
--cc=jbaron@akamai.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
--cc=tj@kernel.org \
--cc=yrl.pp-manager.tt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome