From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
Mans Rullgard <mans@mansr.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Nicolas Pitre <nico@linaro.org>, Tony Lindgren <tony@atomide.com>,
Sebastian Frias <sebastian_frias@sigmadesigns.com>
Subject: Re: [PATCH] clocksource: Store reg field within struct clocksource
Date: Thu, 19 Nov 2015 10:40:00 +0000 [thread overview]
Message-ID: <20151119104000.GW8644@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <alpine.DEB.2.11.1511191134120.3898@nanos>
On Thu, Nov 19, 2015 at 11:36:53AM +0100, Thomas Gleixner wrote:
> On Thu, 19 Nov 2015, Russell King - ARM Linux wrote:
> > Maybe the ____cacheline_aligned is inappropriate then, because it means
> > any wrapping of struct clocksource has exactly the same problem.
>
> We could do that, but that does not necessarily solve the cache
> footprint issue. Aside of that we'd need to add ____cacheline_aligned
> to quite some of the statically allocated clocksource declarations.
Sorry, but it does solve the cache footprint issue, because it would
have the effect of moving 'reg' right into the same cache line as
the 'read' pointer.
Yes, we'd need ____cacheline_aligned at the static declarations, but
surely that's better than constantly having to stuff implementation
specific data into struct clocksource.
--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-11-19 10:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 13:43 Marc Gonzalez
2015-11-18 13:51 ` Måns Rullgård
2015-11-18 17:21 ` Russell King - ARM Linux
2015-11-19 9:27 ` Marc Gonzalez
2015-11-19 10:33 ` Russell King - ARM Linux
2015-11-19 10:36 ` Thomas Gleixner
2015-11-19 10:40 ` Russell King - ARM Linux [this message]
2015-11-19 10:33 ` Thomas Gleixner
2015-11-19 10:36 ` Russell King - ARM Linux
2015-11-19 10:42 ` Thomas Gleixner
2015-11-19 11:08 ` Russell King - ARM Linux
2015-11-19 11:14 ` Thomas Gleixner
2015-11-19 12:26 ` Marc Gonzalez
2015-11-19 13:57 ` Thomas Gleixner
2015-11-24 12:36 ` Marc Gonzalez
2015-11-25 21:33 ` [tip:timers/core] timekeeping: Lift clocksource cacheline restriction tip-bot for Thomas Gleixner
2015-11-19 10:55 ` [PATCH] clocksource: Store reg field within struct clocksource Marc Gonzalez
2015-11-19 11:21 ` Russell King - ARM Linux
2015-11-19 12:41 ` Marc Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151119104000.GW8644@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mans@mansr.com \
--cc=marc_gonzalez@sigmadesigns.com \
--cc=nico@linaro.org \
--cc=sebastian_frias@sigmadesigns.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®