From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759416AbbKSWOy (ORCPT ); Thu, 19 Nov 2015 17:14:54 -0500 Received: from mail-yk0-f173.google.com ([209.85.160.173]:35730 "EHLO mail-yk0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759292AbbKSWOv (ORCPT ); Thu, 19 Nov 2015 17:14:51 -0500 Date: Thu, 19 Nov 2015 17:14:47 -0500 From: Tejun Heo To: Ilya Dryomov Cc: Christoph Hellwig , "linux-kernel@vger.kernel.org" , linux-fsdevel@vger.kernel.org, Ceph Development Subject: Re: request_queue use-after-free - inode_detach_wb() Message-ID: <20151119221447.GB4885@mtj.duckdns.org> References: <20151117205641.GF22864@mtj.duckdns.org> <20151118153039.GA11496@mtj.duckdns.org> <20151119211831.GA4885@mtj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Thu, Nov 19, 2015 at 10:56:43PM +0100, Ilya Dryomov wrote: > Detaching the inode earlier is what I suggested in the first email, but > I didn't know if this kind of special casing was OK. I'll try it out. Yeah, I was confused. Sorry about that. On the surface, it looks like a special case but everything around bdev is special case anyway and looking at the underlying lifetime rules, I think this is the right thing to do. Thanks. -- tejun