From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162411AbbKTI6X (ORCPT ); Fri, 20 Nov 2015 03:58:23 -0500 Received: from mail-pa0-f52.google.com ([209.85.220.52]:32790 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161067AbbKTI6V (ORCPT ); Fri, 20 Nov 2015 03:58:21 -0500 Date: Fri, 20 Nov 2015 14:28:15 +0530 From: Sudip Mukherjee To: Stephen Boyd Cc: Michael Turquette , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH] clk: versatile: fix memory leak Message-ID: <20151120085815.GB4485@sudip-pc> References: <1447681600-14120-1-git-send-email-sudipm.mukherjee@gmail.com> <20151118222446.GG32672@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151118222446.GG32672@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 18, 2015 at 02:24:46PM -0800, Stephen Boyd wrote: > On 11/16, Sudip Mukherjee wrote: > > If of_clk_parent_fill() fails then we printed an error message and > > returned. But we missed freeing sp810. > > > > Signed-off-by: Sudip Mukherjee > > --- > > Applied to clk-next Thanks. > > We don't need that error message on allocation failure either. I sent another patch to remove the error message on kzalloc failure. Did you mean that one or did you mean the error message for of_clk_parent_fill()? I could not find any message being printed if of_clk_parent_fill() fails so kept it as it is. regards sudip