mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Liviu Dudau <Liviu.Dudau@arm.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	DRI devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 0/3] drm/i2c: tda998x: Add support for atomic modesetting.
Date: Fri, 20 Nov 2015 16:54:10 +0000	[thread overview]
Message-ID: <20151120165409.GG8644@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20151120164455.GK4158@e106497-lin.cambridge.arm.com>

On Fri, Nov 20, 2015 at 04:44:55PM +0000, Liviu Dudau wrote:
> On Fri, Nov 20, 2015 at 04:32:59PM +0000, Russell King - ARM Linux wrote:
> > On Fri, Nov 20, 2015 at 02:24:04PM +0000, Liviu Dudau wrote:
> > > On Wed, Nov 11, 2015 at 05:57:18PM +0000, Liviu Dudau wrote:
> > > > On Wed, Nov 11, 2015 at 05:51:52PM +0000, Russell King - ARM Linux wrote:
> > > > > On Wed, Nov 11, 2015 at 03:34:32PM +0000, Liviu Dudau wrote:
> > > > > > While going through the code testing I've noticed an unbalanced
> > > > > > .unbind missing drm_connector_unregister()
> > > > > 
> > > > > That actually doesn't matter, as DRM automatically tears them down anyway,
> > > > > so this isn't an urgent change.  However, it's good practice to do so.
> > > > 
> > > > It looks like it doesn't, or at least not if the error code is -EPROBE_DEFER.
> > > > On Juno, where the clocks are provided by SCPI and the load order is not
> > > > guaranteed, the first bind will fail with -EPROBE_DEFER but the sysfs entry
> > > > is not cleaned up, so on the next attempt the drm_connector_register() call
> > > > will fail.
> > > > 
> > > > Best regards,
> > > > Liviu
> > > 
> > > Gentle ping. Russell, are you happy with this patchset? If so, would you mind
> > > giving me your Acks?
> > 
> > As I'm the maintainer for the driver, I'll merge it, thanks.
> 
> Cheers!
> 
> Do I need to do anything?

The easy way to ensure that it doesn't get forgotten is to put it in my
patch system, just like ARM patches do.  It'll then nag me each time I
look at it (and also means I don't have to save it out, copy it across
to the machine with the git tree on it, and then apply it there...)

Thanks.

-- 
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

      reply	other threads:[~2015-11-20 16:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-11 15:34 Liviu Dudau
2015-11-11 15:34 ` [PATCH 1/3] drm/i2c: tda998x: Unregister the connector in the unbind function Liviu Dudau
2015-11-11 15:34 ` [PATCH 2/3] drm/i2c: tda998x: Increase the supported dotclock frequency to 165MHz for TDA19988 Liviu Dudau
2015-11-11 15:34 ` [PATCH 3/3] drm/i2c: tda998x: Add support for atomic modesetting Liviu Dudau
2015-11-11 17:51 ` [PATCH 0/3] " Russell King - ARM Linux
2015-11-11 17:57   ` Liviu Dudau
2015-11-20 14:24     ` Liviu Dudau
2015-11-20 16:32       ` Russell King - ARM Linux
2015-11-20 16:44         ` Liviu Dudau
2015-11-20 16:54           ` Russell King - ARM Linux [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151120165409.GG8644@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=Liviu.Dudau@arm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®