From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1163419AbbKTUk1 (ORCPT ); Fri, 20 Nov 2015 15:40:27 -0500 Received: from mail-yk0-f171.google.com ([209.85.160.171]:35657 "EHLO mail-yk0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760513AbbKTUkY (ORCPT ); Fri, 20 Nov 2015 15:40:24 -0500 Date: Fri, 20 Nov 2015 15:40:20 -0500 From: Tejun Heo To: Nina Schiff Cc: davem@davemloft.net, daniel.wagner@bmw-carit.de, nhorman@tuxdriver.com, netdev@vger.kernel.org, lizefan@huawei.com, hannes@cmpxchg.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH RESEND] cgroups: Allow dynamically changing net_classid Message-ID: <20151120204020.GA1574@mtj.duckdns.org> References: <1448051499-1885574-1-git-send-email-ninasc@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448051499-1885574-1-git-send-email-ninasc@fb.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Fri, Nov 20, 2015 at 12:31:39PM -0800, Nina Schiff wrote: > The classid of a process is changed either when a process is moved to > or from a cgroup or when the net_cls.classid file is updated. > Previously net_cls only supported propogating these changes to the > cgroup's related sockets when a process was added or removed from the > cgroup. This means it was neccessary to remove and re-add all processes > to a cgroup in order to update its classid. This change introduces > support for doing this dynamically - i.e. when the value is changed in > the net_cls_classid file, this will also trigger an update to the > classid associated with all sockets controlled by the cgroup. > This mimics the behaviour of other cgroup subsystems. > net_prio circumvents this issue by storing an index into a table with > each socket (and so any updates to the table, don't require updating > the value associated with the socket). net_cls, however, passes the > socket the classid directly, and so this additional step is needed. > > Signed-off-by: Nina Schiff Acked-by: Tejun Heo This was broken from the beginning. Thanks for fixing this. BTW, this will cause a context conflict with the cgroup2 match patches. I'll update the patchset once this lands in net-next. -- tejun