From: Mark Brown <broonie@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Support Opensource <support.opensource@diasemi.com>
Subject: Re: [PATCH v3 1/2] ASoC: da7218: Add bindings documentation for DA7218 audio codec
Date: Sat, 21 Nov 2015 12:52:52 +0000 [thread overview]
Message-ID: <20151121125252.GD26072@sirena.org.uk> (raw)
In-Reply-To: <20151120155351.GA13917@rob-hp-laptop>
[-- Attachment #1: Type: text/plain, Size: 952 bytes --]
On Fri, Nov 20, 2015 at 09:53:51AM -0600, Rob Herring wrote:
> On Thu, Nov 19, 2015 at 01:59:34PM +0000, Adam Thomson wrote:
> > +- VDD-supply: VDD power supply for the device
> > +- VDDMIC-supply: VDDMIC power supply for the device
> > +- VDDIO-supply: VDDIO power supply for the device
> These should be lower case (that is documented in ePAPR BTW :)).
Does that actually make a meaningful difference to anything? Things end
up this way because the strings we use to request the supplies end up in
the property names, we've also got a few other things like representing
microvolts as uV which just look very wrong when written all lowercase.
We could work around it for the supply names by force lowercasing the
name if we don't find the property with the passed name (to avoid
breaking existing users) though.
There's a bunch of stuff in ePAPR that we're ignoring, and a bunch of
other stuff that has no real value like the class naming stuff.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-11-21 12:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 13:59 [PATCH v3 0/2] ASoC: Add support for DA7217 and DA7218 audio codecs Adam Thomson
2015-11-19 13:59 ` [PATCH v3 1/2] ASoC: da7218: Add bindings documentation for DA7218 audio codec Adam Thomson
2015-11-20 15:53 ` Rob Herring
2015-11-21 12:52 ` Mark Brown [this message]
2015-11-23 11:51 ` Opensource [Adam Thomson]
2015-11-19 13:59 ` [PATCH v3 2/2] ASoC: codecs: Add da7218 codec driver Adam Thomson
2015-11-19 18:29 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151121125252.GD26072@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=support.opensource@diasemi.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome