Re: [PATCH] regulator: of: simplifing the parsing code

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]

On Sat, Nov 21, 2015 at 07:41:54PM +0530, Saurabh Sengar wrote:
> On 21 November 2015 at 18:52, Mark Brown <broonie@kernel.org> wrote:
> > On Fri, Nov 20, 2015 at 01:27:27PM +0530, Saurabh Sengar wrote:

> > No, they can't - the values we set for modes in the DT are defined per
> > regulator and we need to translate these into the regulator API
> > definitions.

> What I want to say is there are only 4 possible values which can be
> set for initial_mode and suspend_state modes:

> #define REGULATOR_MODE_FAST                     0x1
> #define REGULATOR_MODE_NORMAL                   0x2
> #define REGULATOR_MODE_IDLE                     0x4
> #define REGULATOR_MODE_STANDBY                  0x8

No, the regulator can specify *any* value in their bindings - they don't
have to be those values, they should be values that are relevant to the
hardware rather than values that mean something in the current regulator
API abstractions.  Things like the values that are specified in the
datasheet for example.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]