From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753281AbbKWVqr (ORCPT ); Mon, 23 Nov 2015 16:46:47 -0500 Received: from smtprelay0065.hostedemail.com ([216.40.44.65]:41543 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751093AbbKWVqp (ORCPT ); Mon, 23 Nov 2015 16:46:45 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2553:2559:2562:2693:2731:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3871:3872:3874:4605:5007:6261:7875:10004:10400:10848:10967:11232:11658:11914:12043:12517:12519:12740:13069:13311:13357:14096:14097:14659:21080:30029:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:4,LUA_SUMMARY:none X-HE-Tag: bulb97_1db111cb38612 X-Filterd-Recvd-Size: 2184 Date: Mon, 23 Nov 2015 16:46:43 -0500 From: Steven Rostedt To: Mathieu Desnoyers Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Peter Zijlstra Subject: Re: [PATCH 2/3] ftrace: add ftrace-buffer option Message-ID: <20151123164643.04f8601d@gandalf.local.home> In-Reply-To: <1446504164-21563-2-git-send-email-mathieu.desnoyers@efficios.com> References: <1446504164-21563-1-git-send-email-mathieu.desnoyers@efficios.com> <1446504164-21563-2-git-send-email-mathieu.desnoyers@efficios.com> X-Mailer: Claws Mail 3.13.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2 Nov 2015 17:42:43 -0500 Mathieu Desnoyers wrote: > In order to use ftrace tracers to generate tracepoints without doing > tracing to its own hardcoded ring buffers, add a ftrace-buffer option > (default: 1). When set to 0, it disables tracing into the ftrace > hardcoded buffers. > This should be a tracer specific option. And it shouldn't be called "ftrace-buffer" as that is a very confusing name. Perhaps I can add an option that will prevent the snapshots as well. Perhaps an option called "quiet", and a "no_snapshot" one too. I can create the no snapshot one. But this should be converted to "quiet" and added as a tracer specific option. -- Steve > Signed-off-by: Mathieu Desnoyers > CC: Thomas Gleixner > CC: Steven Rostedt > CC: Ingo Molnar > CC: Peter Zijlstra > --- > kernel/trace/trace.c | 4 +++- > kernel/trace/trace.h | 1 + > kernel/trace/trace_irqsoff.c | 19 +++++++++++-------- > 3 files changed, 15 insertions(+), 9 deletions(-)