From: Peter Zijlstra <peterz@infradead.org>
To: Lianwei Wang <lianwei.wang@gmail.com>
Cc: linux-kernel@vger.kernel.org,
linux-pm@lists.linux-foundation.org, rjw@rjwysocki.net,
mingo@redhat.com
Subject: Re: [PATCH] sched: idle: move need_resched check after function rcu_idle_enter
Date: Mon, 23 Nov 2015 18:57:54 +0100 [thread overview]
Message-ID: <20151123175754.GL17308@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <CAJFUiJg_2AfuvDnRKc_G7N78ty5jjVAGcHFyeJbfFkHALsLubQ@mail.gmail.com>
On Mon, Nov 23, 2015 at 09:42:06AM -0800, Lianwei Wang wrote:
> Issue was found on ARM/Qcom platform, but I think it is applicable to
> other platforms as well. I add a BUG_ON after rcu_enter_idle to catch
> it. The Qcom's cpuidle driver is not in mainline kernel yet.
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
And I suspect that your qualcom thing doesn't have TIF_POLLING_NRFLAG
either, which would introduce another need_resched() test after the
rcu_enter_idle() call.
next prev parent reply other threads:[~2015-11-23 17:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-21 9:02 Lianwei Wang
2015-11-23 13:05 ` Peter Zijlstra
2015-11-23 17:42 ` Lianwei Wang
2015-11-23 17:57 ` Peter Zijlstra [this message]
2015-11-23 20:02 ` Lianwei Wang
2015-11-23 17:59 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151123175754.GL17308@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=lianwei.wang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mingo@redhat.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®