From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754755AbbKXQ21 (ORCPT ); Tue, 24 Nov 2015 11:28:27 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:42437 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753861AbbKXQ2Z (ORCPT ); Tue, 24 Nov 2015 11:28:25 -0500 Date: Tue, 24 Nov 2015 11:28:23 -0500 (EST) Message-Id: <20151124.112823.788627506827225852.davem@davemloft.net> To: arnd@arndb.de Cc: netdev@vger.kernel.org, f.fainelli@gmail.com, andrew@lunn.ch, rmk+kernel@arm.linux.org.uk, linux-kernel@vger.kernel.org, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] net: dsa: include gpio consumer header file From: David Miller In-Reply-To: <6383467.TZ5s6u4A6T@wuerfel> References: <6383467.TZ5s6u4A6T@wuerfel> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 24 Nov 2015 08:28:25 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Tue, 24 Nov 2015 12:34:49 +0100 > After the introduction of the switch gpio reset API, I'm getting > build errors in configurations that disable CONFIG_GPIOLIB: > > net/dsa/dsa.c:783:16: error: implicit declaration of function 'gpio_to_desc' [-Werror=implicit-function-declaration] > > The reason is that linux/gpio/consumer.h is not automatically > included without gpiolib support. This adds an explicit #include > statement to make it compile in all configurations. The reset > functionality will not work without gpiolib, which is what you > get when disabling the feature. > > As far as I can tell, gpiolib is supported on all architectures > on which you can have DSA at the moment. > > Signed-off-by: Arnd Bergmann > Fixes: cc30c16344fc ("net: dsa: Add support for a switch reset gpio") Applied, thanks.