From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: peterz@infradead.org, tatsu@ab.jp.nec.com, mingo@redhat.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
jolsa@redhat.com, eric.dumazet@gmail.com
Subject: Re: net: Generalise wq_has_sleeper helper
Date: Tue, 24 Nov 2015 16:30:25 -0500 (EST) [thread overview]
Message-ID: <20151124.163025.1551408934471757005.davem@davemloft.net> (raw)
In-Reply-To: <20151124055423.GA31611@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Tue, 24 Nov 2015 13:54:23 +0800
> On Wed, Nov 11, 2015 at 05:48:29PM +0800, Herbert Xu wrote:
>>
>> BTW, the networking folks found this years ago and even added
>> helpers to deal with this. See for example wq_has_sleeper in
>> include/net/sock.h. It would be good if we can move some of
>> those helpers into wait.h instead.
>
> Here is a patch against net-next which makes the wq_has_sleeper
> helper available to non-next users:
>
> ---8<---
> The memory barrier in the helper wq_has_sleeper is needed by just
> about every user of waitqueue_active. This patch generalises it
> by making it take a wait_queue_head_t directly. The existing
> helper is renamed to skwq_has_sleeper.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
I'm fine with wherever this patch goes. Herbert is there any
particular tree where it'll facilitate another user quickest?
Or should I just toss it into net-next?
Acked-by: David S. Miller <davem@davemloft.net>
next prev parent reply other threads:[~2015-11-24 21:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 8:01 [PATCH v2] wait: add comment before waitqueue_active noting memory barrier is required Kosuke Tatsukawa
2015-10-22 12:56 ` Peter Zijlstra
2015-10-22 23:18 ` Kosuke Tatsukawa
2015-10-23 12:40 ` Peter Zijlstra
2015-11-11 9:48 ` Herbert Xu
2015-11-24 5:54 ` net: Generalise wq_has_sleeper helper Herbert Xu
2015-11-24 21:30 ` David Miller [this message]
2015-11-25 1:10 ` Herbert Xu
2015-11-25 9:15 ` Peter Zijlstra
2015-11-25 16:37 ` David Miller
2015-11-26 5:55 ` [PATCH v2] " Herbert Xu
2015-11-30 19:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151124.163025.1551408934471757005.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tatsu@ab.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®