From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755262AbbKXVqc (ORCPT ); Tue, 24 Nov 2015 16:46:32 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:46280 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755228AbbKXVq2 (ORCPT ); Tue, 24 Nov 2015 16:46:28 -0500 Date: Tue, 24 Nov 2015 16:46:25 -0500 (EST) Message-Id: <20151124.164625.1632013093413416374.davem@davemloft.net> To: mkubecek@suse.cz Cc: yoshfuji@linux-ipv6.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org, kuznet@ms2.inr.ac.ru, jmorris@namei.org, kaber@trash.net, pablo@netfilter.org, kadlec@blackhole.kfki.hu Subject: Re: [PATCH net] ipv6: distinguish frag queues by device for multicast and link-local packets From: David Miller In-Reply-To: <20151124140711.E07F2A0BE8@unicorn.suse.cz> References: <20151124140711.E07F2A0BE8@unicorn.suse.cz> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 24 Nov 2015 13:46:27 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Michal Kubecek Date: Tue, 24 Nov 2015 15:07:11 +0100 (CET) > If a fragmented multicast packet is received on an ethernet device which > has an active macvlan on top of it, each fragment is duplicated and > received both on the underlying device and the macvlan. If some > fragments for macvlan are processed before the whole packet for the > underlying device is reassembled, the "overlapping fragments" test in > ip6_frag_queue() discards the whole fragment queue. > > To resolve this, add device ifindex to the search key and require it to > match reassembling multicast packets and packets to link-local > addresses. > > Note: similar patch has been already submitted by Yoshifuji Hideaki in > > http://patchwork.ozlabs.org/patch/220979/ > > but got lost and forgotten for some reason. > > Signed-off-by: Michal Kubecek This is definitely the right thing to do and matches how ipv4 keys fragments. Applied and queued up for -stable, thanks!