mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: "Andrew F. Davis" <afd@ti.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Lee Jones <lee.jones@linaro.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/4] regulator: tps65086: Add regulator driver for the TPS65086 PMIC
Date: Tue, 24 Nov 2015 12:11:55 +0000	[thread overview]
Message-ID: <20151124121155.GK1929@sirena.org.uk> (raw)
In-Reply-To: <56536677.5070102@ti.com>

[-- Attachment #1: Type: text/plain, Size: 881 bytes --]

On Mon, Nov 23, 2015 at 01:18:15PM -0600, Andrew F. Davis wrote:

> Right, so this is the kind of description that would be nice with the
> declaration.

Feel free to send patches for the documentation, bearing in mind that
there is a limit to how large we cna make it.

> >>in the config takes precedence over the one in config->dev, the
> >>opposite is true for regulators, this is very confusing and should be
> >>standardized.

> >No, they both do the same thing.

> I don't see that, config->dev->of_node is checked for the init data in
> regulator_of_get_init_data, then config->of_node is then ignored if that
> succeeds.

Right, like I say this is because nobody should ever actually be using
that capability if they also have good bindings.  If anyone did have a
sensible use case that'd be where it would go but as things stand they
will be pushed to do the right thing.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2015-11-24 12:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-19 23:01 [PATCH v4 0/4] Add support for the TI " Andrew F. Davis
2015-11-19 23:01 ` [PATCH v4 1/4] Documentation: tps65086: Add DT bindings for the " Andrew F. Davis
2015-11-20 16:33   ` Rob Herring
2015-11-23 16:09   ` Lee Jones
2015-11-19 23:01 ` [PATCH v4 2/4] mfd: tps65086: Add driver " Andrew F. Davis
2015-11-23 16:20   ` Lee Jones
2015-11-19 23:01 ` [PATCH v4 3/4] regulator: tps65086: Add regulator " Andrew F. Davis
2015-11-21 13:37   ` Mark Brown
2015-11-21 20:40     ` Andrew F. Davis
2015-11-22 13:13       ` Mark Brown
2015-11-23 17:40         ` Andrew F. Davis
2015-11-23 19:00           ` Mark Brown
2015-11-23 19:18             ` Andrew F. Davis
2015-11-24 12:11               ` Mark Brown [this message]
2015-11-19 23:01 ` [PATCH v4 4/4] gpio: tps65086: Add GPO " Andrew F. Davis
2015-11-30  8:50   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151124121155.GK1929@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=afd@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=gnurou@gmail.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®