mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: romieu@fr.zoreil.com
Cc: jarod@redhat.com, ldap.tester@gmail.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: severe regression in alx ethernet driver
Date: Wed, 25 Nov 2015 23:10:08 -0500 (EST)	[thread overview]
Message-ID: <20151125.231008.347752016459161329.davem@davemloft.net> (raw)
In-Reply-To: <20151125224708.GA1640@electric-eye.fr.zoreil.com>

From: Francois Romieu <romieu@fr.zoreil.com>
Date: Wed, 25 Nov 2015 23:47:08 +0100

> Jarod Wilson <jarod@redhat.com> :
> [...]
>> They do at least have a signed-off-by in the patches attached to the bug,
>> so I'm working on touching up the descriptions and formatting, regression
>> testing them on my laptop that has an alx-driven E2200 in it (which isn't
>> affected by this bug), and then I can ship them up for proper review.
> 
> You can forget the last refill-me-harder patch and save a roundtrip.
> The driver should 1) prohibit holes in its receive ring, 2) allocate before
> pushing data up in the stack and 3) drop packets when it can't allocate a
> fresh buffer.

+1

      reply	other threads:[~2015-11-26  4:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-14 21:47 Ldap Tester
2015-11-23 14:00 ` Ldap Tester
2015-11-23 16:15   ` David Miller
2015-11-23 16:16     ` David Miller
2015-11-24 16:07       ` Jarod Wilson
2015-11-25 22:47         ` Francois Romieu
2015-11-26  4:10           ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151125.231008.347752016459161329.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jarod@redhat.com \
    --cc=ldap.tester@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®