From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932160AbbKYB2X (ORCPT ); Tue, 24 Nov 2015 20:28:23 -0500 Received: from LGEAMRELO12.lge.com ([156.147.23.52]:43011 "EHLO lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754255AbbKYB2T (ORCPT ); Tue, 24 Nov 2015 20:28:19 -0500 X-Original-SENDERIP: 156.147.1.126 X-Original-MAILFROM: namhyung@kernel.org X-Original-SENDERIP: 165.244.98.76 X-Original-MAILFROM: namhyung@kernel.org X-Original-SENDERIP: 10.177.227.17 X-Original-MAILFROM: namhyung@kernel.org Date: Wed, 25 Nov 2015 10:27:45 +0900 From: Namhyung Kim To: Steven Rostedt CC: Tom Zanussi , daniel.wagner@bmw-carit.de, masami.hiramatsu.pt@hitachi.com, josh@joshtriplett.org, andi@firstfloor.org, mathieu.desnoyers@efficios.com, peterz@infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v12 01/30] tracing: Update cond flag when enabling or disabling a trigger Message-ID: <20151125012745.GB6171@sejong> References: <20151123162943.469b3f66@gandalf.local.home> MIME-Version: 1.0 In-Reply-To: <20151123162943.469b3f66@gandalf.local.home> User-Agent: Mutt/1.5.24 (2015-08-30) X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB03/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2015/11/25 10:27:45, Serialize by Router on LGEKRMHUB03/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2015/11/25 10:27:45, Serialize complete at 2015/11/25 10:27:45 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Steve and Tom, On Mon, Nov 23, 2015 at 04:29:43PM -0500, Steven Rostedt wrote: > On Mon, 23 Nov 2015 13:51:16 -0600 > Tom Zanussi wrote: > > > When a trigger is enabled, the cond flag should be set beforehand, > > otherwise a trigger that's expecting to process a trace record > > (e.g. one with post_trigger set) could be invoked without one. > > > > Likewise a trigger's cond flag should be reset after it's disabled, > > not before. > > > > Signed-off-by: Tom Zanussi > > Signed-off-by: Daniel Wagner > > Reviewed-by: Masami Hiramatsu > > Tested-by: Masami Hiramatsu > > --- > > FYI, I've applied this patch as it looks like something that should be > added regardless of the rest of the series. You can add my Reviewed-by if you want. I'll try to review others soon. Thanks, Namhyung