From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932384AbbKYB7W (ORCPT ); Tue, 24 Nov 2015 20:59:22 -0500 Received: from mail-bn1on0067.outbound.protection.outlook.com ([157.56.110.67]:52105 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932230AbbKYB7T (ORCPT ); Tue, 24 Nov 2015 20:59:19 -0500 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; alien8.de; dkim=none (message not signed) header.d=none;alien8.de; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0NYCLIP-07-3FW-02 X-M-MSG: Date: Wed, 25 Nov 2015 09:59:18 +0800 From: Huang Rui To: Guenter Roeck CC: Wim Van Sebroeck , , , Denis Turischev , Borislav Petkov , Vincent Wan , Tony Li Subject: Re: [PATCH 1/2] sp5100_tco: fix the device check for SB800 and later chipsets Message-ID: <20151125015916.GA2904@hr-amur2> References: <1448273256-1793-1-git-send-email-ray.huang@amd.com> <56546CEB.3080907@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <56546CEB.3080907@roeck-us.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(164054003)(199003)(24454002)(189002)(479174004)(377454003)(105586002)(92566002)(19580395003)(5008740100001)(19580405001)(97736004)(11100500001)(47776003)(86362001)(50986999)(97756001)(23726003)(586003)(1076002)(46406003)(83506001)(4001350100001)(106466001)(87936001)(101416001)(50466002)(5007970100001)(189998001)(33656002)(110136002)(33716001)(54356999)(77096005)(76176999)(2950100001)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR12MB0709;H:atltwp01.amd.com;FPR:;SPF:None;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0709;2:surGPc0uUFl2mmEtyMCpYYhblLUecrBwT9gvHhwLJgykkiL+ru00tMf65MwcXe1cHP4jN0/OqylYrANGJ0bt51nlAIsNW+DFnGsR0k0TYXjhd6CDl4Qm6ElDgh0qHJM8gDWXrRVeEHqS7jegFEgwGA==;3:tvuARCagTGeenqvj4/3ZhYvimJEtI8I6IADOITYbh/ZkLIYi7X0WBuUKIn5TT4sYtJPZliz5iECnDsdHNGvjDcUPJuNmann7Fi+IsF0rMioFWiQyob2/rRCI+BwYMJoF0QOAx4lRpp0a3XrKyylKtUhZHb4HDNWpIqcGwdu3J99zUWpfuziGmOQubTj75Cuhq0+G51lEEJCUBH9ruVu5p+ozqz8d6h6McJyKWoAQG4s=;25:Uzr11RXC1My5wRXZq+Xn0Vigjf4Oii2VflwIQ2Um06cmOlg56Zm1dxnth4priNhrEaf187TLb7DXtNBYI2PQXj707q7v33rtqsnlbY9g35Vs7H7KoYmhKYNsS9fbKl7EjswVoxUzFMz6Dvj4O8NRfx94vcMzYvZX9r9/3tqbcwEDb2NU8PM9aAic+haeNFwnT1Jt4RIUNuaaT4iJB5d85IdGFDzMgZcXNl542x0k1zDqjmt8SsiDNhm7+3onVRR1bFqzPNfqJXjjbNDRP98a3Q== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR12MB0709; X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0709;20:cEpr3cif6jgk98aP0ZDw8LKh2hZnmzKFQqo8ys+vwu4O559F+Pvao1fW5/AqtQflYz0BsYTM7DXEHbGdz1z/vAV8mZF9ldQpuCwk8tjBvCjrrx4YeMbXgaBhpTpKVB7tzSdrlAB7Yr+R+sXpjxJS7w+sh93f1zorUTE6MhC2Cqo4MdNUkFEbeUzUg3DqWbrfvNFMjGz86CkAX61nC8+O8B6zCJbCxpL5YWkl4Ofe462jS5fu2VTYEoFzMEaTC9oaha8l3Whv7SuxP6jRIpbj/Ays6CfhUudqhpc+QPfjNbOX38tk0YLwA2ISfYBX18DpVBTxhtP5JwUJApZ+vElW+3Rnmydb5Gh9afIg5ZjeCm7B1msrq3Tg5rpQC1/5o+RyobEv0Yzu5DMb1AbwHg2k5cwdOz4zkTVO8oOhfAhery4wLq1Zd3fI34HpfSInhuTQ+O13FLHoEr3krezxquJF68FEPazYcri/lS7xp+XIukhztBUgelLj9cPvXIw4dc5q;4:ITc8YOMSlgeQ9lpd+sob9XJRyfHsC+GA2JuYvNNqai+JeuHpfx2nSKZX2v1KpbJcKHxud3NGMzhNODEM3ThMY1PGMLA+lVhBpGqGqJg2S0G74vCCTQRcp8sbr007TNPx66t7iKWsxA/KHVYDigsPytTFjMuByP5HCCVctw6L6A6bKfexcH3w6wS3cYX/HJAwLb3jWlob2mGfRo5m9LY89jUXJAUqle6AULnmX/JhTWk2i8JTR5ADDW1IPI6Bh6immoiuzuvuXxdqiluKmbKVXv3OkN1KSbuzeReLtbPfxOCEjfn5q3bhyQNAX7COPacHxJruvtCrD9WDBZ2Y1A97yEa7zjHvgVl5Eu7TgqCUiS6QqWAsGkoN2Rir+YbCPmaX98oXBtUlPcGodVny0bzqJchdVRCRuet+imKVCt8YHAs= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001)(10201501046);SRVR:BY2PR12MB0709;BCL:0;PCL:0;RULEID:;SRVR:BY2PR12MB0709; X-Forefront-PRVS: 0771670921 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY2PR12MB0709;23:C1dPV2AfoFi2dkRovc3r40Faeu+wSXph7kfK3yGDv?= =?us-ascii?Q?qItGsXV5C329L38+3Llk51D9pagLzdUCCUdvrnmzRvNvffgkDJPeh8O4Y4sd?= =?us-ascii?Q?Etdz3+B4II/e/l33us/REyQvU1yvwGKrnwPSiA1/3L4HNsKx2HpWRWxxx3aG?= =?us-ascii?Q?H8hqT66FWuEO4XeCMqU199GGAtxjuuMGZlyUr5nkYtozJRFLmfErtwCRQ9RU?= =?us-ascii?Q?EVTiKfJ84VZ38x/33wJkb+0mn3ddmepa+8fsQLAeiwJqG2jDuMEThJ+6LCa8?= =?us-ascii?Q?U6ZBBrgKE0s2Tf7TgPnTE1pRnp1fNQFeAUTHcbP3AjMbf77VKTtyTq+NCzpB?= =?us-ascii?Q?T3Q2+/32FtWheNRCi9D/FPQL+aY8/Qzt0wki+aNSzxMJJU0sCRI8okpbA4Sf?= =?us-ascii?Q?OM2+KR8uQVsVusEtqqGDtaEv1597nmTpc7oGLN0ryLo0e2osTmPHt7/lEzFv?= =?us-ascii?Q?bQ7amN2F20BkeM1UmVne93c5G62kVGlPq0ZNNtQ9pgdmEHmXEkbdeNd45IR3?= =?us-ascii?Q?A9jEOidCZLlyx+b1eE5wW86SDGbco1J3mTvvRtLuM+COxN4WdQkZlCoW2zln?= =?us-ascii?Q?l9FPTe680WI5Py/qIE+zEjk7cQM6GbIsdfut2hB0qorjeB/eScD+IXQKhRPT?= =?us-ascii?Q?MosnTyL4H+13Rf9eFGi+fa3EaCxgl/0YOTVSvR8ZtaiRAdoqHUb+YDhI9Yg8?= =?us-ascii?Q?oYAngRE721wCsydHC12+JI0Si+9jJe2eTuFSkG+a46nfXHxguJMf8CmyedBU?= =?us-ascii?Q?Wx/dMtkg6QDDgRaH0whJQ7r4cZAGQOOncMUphtrgI46KuAFvEU1hfeSFfxOw?= =?us-ascii?Q?eBqs+3HUPCdxVbF16VOCt1JtCoqd1NqaYnoIwCKWDhqxGiV4J8HxHLcyskt3?= =?us-ascii?Q?viSrqNgnYPO1xwkwN/bVqagC5yfaTpJ4G5i7zLz8lXxzVF+eCbGM67X376gz?= =?us-ascii?Q?SdUBwf3hXB5OCRWr9M2K7CWtapOkrgmBKPgwLlUVzdfdvqQxlP4+2VcL0n8D?= =?us-ascii?Q?YIAnf4acaTfgP+0ZA6aU4RJm4mHUEywPSFmM+SBa4t0UFz5d0RZT7GGVVqzx?= =?us-ascii?Q?J9n7IsEk3zJk+f+88QVFunFvRNs?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0709;5:ykhJNPFJS/ygKHUYA1wHVWcwvD6W24VPO6Uj1fXy/oGIvZrAleywnYgXYH95dXDNXSYzlms7iolABMwefS46Rl+cI20IoDzWXKH2xhXSHsDJ2tTgKqdX0kNuVwwjeZl28GsOPmjBdayc0iZwop5bkw==;24:zHRzRSCx3tiE+Vyhg0jTJMrubvSzU2nnEv6vfxpXgHnXPyCH7dAA6KxHdj9vPZmQ6HUPeccbvnfTrm1TGpbYPOWm0zW4H7rLK4leyD5jv+Y=;20:CqSlNXfowD+SFtZA+SntStD1UoPSssaU6lShsBMuktSYsAwyMkOywX+5nl6Cj1srOUP2OWIwyRn89Ap8bqvVmx2IqZam4xo2N+1Dr/+ur/+fJ47ZFGlWdegQ2Bn4tPtpm59hB8Z3RHx7icrtOJ8ifVqjZRJCyG/0fUF2l/3QHZK4ixcD/TkuVqr2Aezog+BBViR5Zc99Lj7qX+VEpndTwI3VCNpWJxVv/dD9tKskZKr9sL7wCZ4xQEFO0ioRtJ9Y SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2015 01:59:14.6277 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR12MB0709 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 24, 2015 at 05:58:03AM -0800, Guenter Roeck wrote: > On 11/23/2015 02:07 AM, Huang Rui wrote: > >For SB800 and later chipsets, the register definitions are the same > >with SB800. And for SB700 and older chipsets, the definitions should > >be same with SP5100/SB7x0. > > > >Signed-off-by: Huang Rui > >Cc: Denis Turischev > > Reviewed-by: Guenter Roeck > > Would it make sense to rework this driver as pci driver ? > I agree with you. Actually, I thought about this stuff. But sp5100 watchdog is not a pci device in AMD chipset. In another word, it doesn't export a pci header to OS. At current, we use SMBus pci device id and vendor id to detect watchdog on the AMD chipset (Because AMD use SMBus device id and revsion to identify different chipset version). At the same time, SMbus has its own driver piix4_smbus. Looks like we don't have a pci header to enumerate the watchdog. Thanks, Rui