From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753444AbbKYMQe (ORCPT ); Wed, 25 Nov 2015 07:16:34 -0500 Received: from foss.arm.com ([217.140.101.70]:39299 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753146AbbKYMQc (ORCPT ); Wed, 25 Nov 2015 07:16:32 -0500 Date: Wed, 25 Nov 2015 12:16:28 +0000 From: Catalin Marinas To: Arnd Bergmann Cc: will.deacon@arm.com, linux-arch@vger.kernel.org, Michal Simek , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM64: fix building without CONFIG_UID16 Message-ID: <20151125121628.GE3109@e104818-lin.cambridge.arm.com> References: <3891403.6hGat7eHq5@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3891403.6hGat7eHq5@wuerfel> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 20, 2015 at 12:12:21PM +0100, Arnd Bergmann wrote: > As reported by Michal Simek, building an ARM64 kernel with CONFIG_UID16 > disabled currently fails because the system call table still needs to > reference the individual function entry points that are provided by > kernel/sys_ni.c in this case, and the declarations are hidden inside > of #ifdef CONFIG_UID16: > > arch/arm64/include/asm/unistd32.h:57:8: error: 'sys_lchown16' undeclared here (not in a function) > __SYSCALL(__NR_lchown, sys_lchown16) > > I believe this problem only exists on ARM64, because older architectures > tend to not need declarations when their system call table is built > in assembly code, while newer architectures tend to not need UID16 > support. ARM64 only uses these system calls for compatibility with > 32-bit ARM binaries. > > This changes the CONFIG_UID16 check into CONFIG_HAVE_UID16, which is > set unconditionally on ARM64 with CONFIG_COMPAT, so we see the > declarations whenever we need them, but otherwise the behavior is > unchanged. > > Signed-off-by: Arnd Bergmann > Cc: stable@vger.kernel.org > Fixes: af1839eb4bd4 ("Kconfig: clean up the long arch list for the UID16 config option") Applied. Thank. -- Catalin