From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752006AbbKYRmg (ORCPT ); Wed, 25 Nov 2015 12:42:36 -0500 Received: from smtprelay0156.hostedemail.com ([216.40.44.156]:37371 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751210AbbKYRm2 (ORCPT ); Wed, 25 Nov 2015 12:42:28 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3871:3872:3874:5007:6261:7875:9010:9038:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12296:12438:12517:12519:12663:12740:13069:13075:13311:13357:14096:14097:14659:21080:30012:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: space40_31df73fa86760 X-Filterd-Recvd-Size: 2106 Date: Wed, 25 Nov 2015 12:42:21 -0500 From: Steven Rostedt To: Jiri Olsa Cc: Jiri Olsa , lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra , Arnaldo Carvalho de Melo Subject: Re: [PATCH 1/2] ftrace: Add separate handler for ftrace:function event Message-ID: <20151125124221.281d6f3d@gandalf.local.home> In-Reply-To: <20151125171243.GA2214@krava.brq.redhat.com> References: <1448466333-28102-1-git-send-email-jolsa@kernel.org> <20151125111956.7d53da99@gandalf.local.home> <20151125165057.GA30914@krava.brq.redhat.com> <20151125120257.17e53cab@gandalf.local.home> <20151125171243.GA2214@krava.brq.redhat.com> X-Mailer: Claws Mail 3.13.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 25 Nov 2015 18:12:43 +0100 Jiri Olsa wrote: > > Yeah, I'm trying to figure out the paths here. I would love to remove > > the control_ops as that complicates the function tracing code a bit > > more than I would like it to be. > > perf is using the control interface to enable and disable function > tracing any time the process (and its events) is scheduled in/out > > sched_in(event) -> ftrace_function_local_enable(&event->ftrace_ops) > sched_out(event) -> ftrace_function_local_disable(&event->ftrace_ops) OK, I think we can merge the control list to the normal list and have something like: (!op->disabled || !ftrace_function_local_disabled(op)) We can also keep the control flag for the ops, and have: !(op->flags & FTRACE_OPS_FL_CONTROL) || rcu_is_watching() test too, and use the ftrace ops list code. -- Steve