From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753594AbbKYMrw (ORCPT <rfc822;w@1wt.eu>);
	Wed, 25 Nov 2015 07:47:52 -0500
Received: from mezzanine.sirena.org.uk ([106.187.55.193]:48196 "EHLO
	mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751622AbbKYMru (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 25 Nov 2015 07:47:50 -0500
Date: Wed, 25 Nov 2015 12:47:28 +0000
From: Mark Brown <broonie@kernel.org>
To: Damien Horsley <Damien.Horsley@imgtec.com>
Cc: alsa-devel@alsa-project.org, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Message-ID: <20151125124728.GT1929@sirena.org.uk>
References: <1448299499-18435-1-git-send-email-Damien.Horsley@imgtec.com>
 <1448299499-18435-3-git-send-email-Damien.Horsley@imgtec.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="iiZKCn1f/U0ES2iY"
Content-Disposition: inline
In-Reply-To: <1448299499-18435-3-git-send-email-Damien.Horsley@imgtec.com>
X-Cookie: A beer delayed is a beer denied.
User-Agent: Mutt/1.5.24 (2015-08-30)
X-SA-Exim-Connect-IP: 94.175.94.161
X-SA-Exim-Mail-From: broonie@sirena.org.uk
Subject: Re: [alsa-devel] [PATCH 2/2] ASoC: img: Add driver for Pistachio
 internal DAC
X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--iiZKCn1f/U0ES2iY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Nov 23, 2015 at 05:24:59PM +0000, Damien Horsley wrote:

> +	/* The mute state as set by alsa using the digital_mute callback */
> +	bool alsa_mute_state;
> +	/* The mute state as set by the userspace mute control */
> +	bool control_mute_state;
> +	/* The actual mute state is equal to an OR of the above */

Does the device *need* the digital mute to avoid noise?  If there's no
strong need for it then just don't bother which simplifies the code a
lot.

Otherwise this looks good.

--iiZKCn1f/U0ES2iY
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJWVa3gAAoJECTWi3JdVIfQ+cgH/0pRLEspJsaHeAVICGG5LWsW
gKixF5k1ih6dXEIbDeFkdacOy7IoMOVaQ0ni0HMLimZl+jO/ncFGrAunsHALwjIk
yzaiVa3IuXWfb+hf34jLfCxJILvT+4v6+JoYWfpAYBzaJZ09M2C6HrBCjKyNjwbG
JLFGeM3FA3YU8RdKKXBNE02v92EFQtUJ3zIiGZShB6+j+jFgCzGlrKWDx2xwL4rO
RDqnP5Sd+HG8yjPz3DtySqAmkdJ739XLXVZfI+SoRLvA7JKcV9B3Lj/l8Dlzr+J7
9i0Ky0uS0VkHMNZOQOWWJvkVt5C2tMGhzAy+s2KDOqIO3bKzmXpuJqDxruEfOaQ=
=mecr
-----END PGP SIGNATURE-----

--iiZKCn1f/U0ES2iY--